Page MenuHomePhabricator

[electrum] fix test_runner.py failure when PyQt5 is not installed
ClosedPublic

Authored by PiRK on Jun 27 2023, 15:22.

Details

Summary

If/when we start adding tests to the electrumabc_gui package, we will need to deal with this. For now, just fix the error by filtering the results returned by unittest.defaultTestLoader.discover

One solution would be to make PyQt5 a requirement for Electrum ABC even when no GUI is needed (I doubt that there is much to test in that package that does not have a hard dependency on Qt).

Depends on D14134

Test Plan

using a virtualenv with only requirements.txt installed (not requirements-binary.txt so no PyQt5), run python electrum/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Jun 27 2023, 15:22
This revision is now accepted and ready to land.Jun 27 2023, 16:01