[ecash-herald] Improve error handling comments in token id info function
ClosedPublic
Actions

Authored by bytesofman on Jun 27 2023, 22:08.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCeda9fdf2cfcc: [ecash-herald] Improve error handling comments in token id info function

Summary

T2972

Depends on D14140

Clear up error logging in getTokenInfoMap function

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

whale-watch

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24222
Build 48054: Build Diff	ecash-herald-tests
Build 48053: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jun 27 2023, 22:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 27 2023, 22:08

bytesofman requested review of this revision.Jun 27 2023, 22:08

Harbormaster completed remote builds in B24222: Diff 41053.Jun 27 2023, 22:09

Fabien accepted this revision.Jun 28 2023, 07:19

This revision is now accepted and ready to land.Jun 28 2023, 07:19

Closed by commit rABCeda9fdf2cfcc: [ecash-herald] Improve error handling comments in token id info function (authored by bytesofman). · Explain WhyJun 28 2023, 17:13

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCeda9fdf2cfcc: [ecash-herald] Improve error handling comments in token id info function.

Revision Contents
Changeset List

Path

Size

apps/

ecash-herald/

src/

chronik.js

8 lines

Diff 41053

View Options

apps/ecash-herald/src/chronik.js

[ecash-herald] Improve error handling comments in token id info functionClosedPublicActions