Dirty job but has to be done at some point. Possible to use this commit as a POC and implement in pieces, but the changes are all related and probably better to rip the bandaid off at once.
Details
Details
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- moar-no-ticker
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 24665 Build 48923: Build Diff cashtab-tests Build 48922: arc lint + arc unit
Event Timeline
Comment Actions
Need to see what this looks like in phab and troubleshoot an error experienced with BalanceHeaderFiat on npm start and in prod build
Comment Actions
npm test
I think the test plan would go beyond just the unit test suite, as there could be unintended effects only felt via manual testing. Given the size of this diff the frontend regression test plan would be huge, so I would feel more comfortable doing this in batches.
Comment Actions
Definitely split into pieces
| cashtab/src/components/Common/Ticker.js | ||
|---|---|---|
| 64 ↗ | (On Diff #41708) | Why are there 2 fiatCurrency/fiatCurrencies data structures ? |