Page MenuHomePhabricator

[electrum] restore tx notification
ClosedPublic

Authored by PiRK on Sep 21 2023, 16:17.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC5b535e813a23: [electrum] restore tx notification
Summary

This was lost in https://github.com/Bitcoin-ABC/ElectrumABC/commit/45fc7d8ad4ee18342d0e2f221138546b2e341be7

Remove indentation levels while we are touching this function.

Test Plan

Run the application in verbose mode (electrum-abc -v), receive a transaction from another wallet (delta amount needs to be > 0, self transfer are negative because of the fee), and check for the log message [ElectrumWindow/test_wallet.TxUpdateMgr] Notifying GUI 1 tx
I'm not sure how to see the actual notifications on Ubuntu, but I remember that there used to be notifs for new transactions in the past.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
tx_notif
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25123
Build 49834: Build Diffelectrum-tests
Build 49833: arc lint + arc unit

Event Timeline

PiRK requested review of this revision.Sep 21 2023, 16:17
This revision is now accepted and ready to land.Sep 21 2023, 17:24
This revision was automatically updated to reflect the committed changes.