Differential D14535

[electrum] pass a wallet.contacts reference to ContactList
ClosedPublic
Actions

Authored by PiRK on Sep 25 2023, 14:59.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC3606c76051e3: [electrum] pass a wallet.contacts reference to ContactList

Summary

Remove some coupling between ContactList and ElectrumWindow.
There is no change in behavior.

Depends on D14534

Test Plan

repeat test plan from D14534

Diff Detail

Repository

rABC Bitcoin ABC

Branch

alias

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25157
Build 49902: Build Diff	electrum-tests
Build 49901: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 25 2023, 14:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 25 2023, 14:59

PiRK requested review of this revision.Sep 25 2023, 14:59

Harbormaster completed remote builds in B25157: Diff 42375.Sep 25 2023, 15:01

bytesofman accepted this revision.Sep 25 2023, 21:07

This revision is now accepted and ready to land.Sep 25 2023, 21:07

Closed by commit rABC3606c76051e3: [electrum] pass a wallet.contacts reference to ContactList (authored by PiRK). · Explain WhySep 26 2023, 05:50

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC3606c76051e3: [electrum] pass a wallet.contacts reference to ContactList.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc_gui/

qt/

contact_list.py

19 lines

main_window.py

2 lines

Diff 42375

View Options

electrum/electrumabc_gui/qt/contact_list.py