The cooldown violation is a time dependent issue that has been observed
on honest nodes facing severe temporary network issues. This cooldown
has been introduced as an DoS prevention mechanism, and is effective at
this. Receiving a poll message is only costly if it is processed by the
node; otherwise it's equivalent to any unknown message that anybody can
already spam on the network. This diff keeps the same cooldown mechanic
but discard the message rather than banning the node, which is the same
behavior as receiving an unknown message. This also fixes the error
message having a funny typo.
Details
Details
- Reviewers
bytesofman PiRK - Group Reviewers
Restricted Project - Commits
- rABC487e77ca0ae5: [avalanche] Don't ban for polling cooldown not elapsed
ninja all check-all
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- avacooldown_tolerance
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 25201 Build 49990: Build Diff build-debug · build-diff · lint-circular-dependencies · build-without-wallet · build-clang · build-clang-tidy Build 49989: arc lint + arc unit
Event Timeline
src/net_processing.cpp | ||
---|---|---|
5045 ↗ | (On Diff #42440) | the whole point is that the issue can occur with honest peers... |