It appears that a peer id is not an inventory type.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC47810b33d3c8: [avalanche] Fix a bug in the avalanche logs
ninja all check
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/net_processing.cpp | ||
|---|---|---|
| 5094 ↗ | (On Diff #42437) | looks like the logic applied before this diff is that inv.type could only be unknown if we get to this default block of the switch statement, the introduced bug was in supplying inv.type as the variable to be logged instead of pfrom.GetId() (guessing a bit, I don't actually know what inv.type could be). If inv.type really is always unknown, then we could just not long the var at all, keep the hardcoded poll inv type unknown If inv.type can be many things but always unrecognized by the switch statement if we get here, could still clarify this, say something like `"unrecognized poll inv type '%d' from peer=%d\n" as suggested |
| src/net_processing.cpp | ||
|---|---|---|
| 5094 ↗ | (On Diff #42437) | The possible values for inv.type is defined at the protocol level, and the node is fully compatible with the eCash P2P protocol. |