Page MenuHomePhabricator
Differential D14575

[Cashtab] Replace obsolete log statement in unit test
ClosedPublic
Actions

Authored by bytesofman on Oct 2 2023, 16:07.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC3149596d668f: [Cashtab] Replace obsolete log statement in unit test
Summary

Use a different error msg for a failed tx broadcast

Depends on D14574

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
send-xec-improvements
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25229
Build 50046: Build Diffcashtab-tests
Build 50045: arc lint + arc unit

Event Timeline

bytesofman created this revision.Oct 2 2023, 16:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 2 2023, 16:07
bytesofman requested review of this revision.Oct 2 2023, 16:07
Harbormaster completed remote builds in B25229: Diff 42489.Oct 2 2023, 16:12
bytesofman added a child revision: D14576: [Cashtab] Add test cases for one-to-many xec sends.Oct 2 2023, 16:30
Fabien requested changes to this revision.Oct 3 2023, 06:43
Fabien added a subscriber: Fabien.

Why is this change not causing a test failure ?

This revision now requires changes to proceed.Oct 3 2023, 06:43
bytesofman added a comment.Oct 3 2023, 14:01
In D14575#327428, @Fabien wrote:

Why is this change not causing a test failure ?

The unit test in this case is showing that the function throws an error on const response = await chronik.broadcastTx(hex); if this chronik server returns an error. So, it's throwing whatever is supplied to the mock. The msg itself is not relevant.

bytesofman requested review of this revision.Oct 3 2023, 14:01
Fabien accepted this revision.Oct 3 2023, 15:38
This revision is now accepted and ready to land.Oct 3 2023, 15:38
Closed by commit rABC3149596d668f: [Cashtab] Replace obsolete log statement in unit test (authored by bytesofman). · Explain WhyOct 3 2023, 17:58
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC3149596d668f: [Cashtab] Replace obsolete log statement in unit test.

Revision Contents
Changeset List

PathSize
cashtab/
src/
transactions/
fixtures/
2 lines

Diff 42489

View Options

cashtab/src/transactions/fixtures/vectors.js

Loading...