Paths

Table of Contentst

Differential D14599

Do not pass CChainParams& to PeerManager::make
ClosedPublic
Actions

Authored by PiRK on Oct 4 2023, 16:18.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC21d3f69b4cdb: Do not pass CChainParams& to PeerManager::make

Summary

This is a partial backport of core#25168
https://github.com/bitcoin/bitcoin/pull/25168/commits/fa30234be81b6f49ae8150478a9255daa1611083

Depends on D14598

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25268
Build 50122: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 50121: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 4 2023, 16:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 4 2023, 16:18

PiRK requested review of this revision.Oct 4 2023, 16:18

teamcity edited the summary of this revision. (Show Details)Oct 4 2023, 16:18

PiRK added a child revision: D14600: Do not call global Params() when chainman is in scope.Oct 4 2023, 16:19

Harbormaster completed remote builds in B25268: Diff 42544.Oct 4 2023, 16:53

Fabien accepted this revision.Oct 4 2023, 18:27

This revision is now accepted and ready to land.Oct 4 2023, 18:27

Closed by commit rABC21d3f69b4cdb: Do not pass CChainParams& to PeerManager::make (authored by PiRK). · Explain WhyOct 5 2023, 03:34

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC21d3f69b4cdb: Do not pass CChainParams& to PeerManager::make.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

4 lines

2 lines

9 lines

26 lines

test/

denialofservice_tests.cpp

20 lines

net_tests.cpp

8 lines

util/

setup_common.cpp

11 lines

Diff 42544

View Options

src/avalanche/test/processor_tests.cpp

View Options

src/init.cpp

View Options

src/net_processing.h

View Options

src/net_processing.cpp

View Options

src/test/denialofservice_tests.cpp

View Options

src/test/net_tests.cpp

View Options

src/test/util/setup_common.cpp

Do not pass CChainParams& to PeerManager::makeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42544

src/avalanche/test/processor_tests.cpp

src/init.cpp

src/net_processing.h

src/net_processing.cpp

src/test/denialofservice_tests.cpp

src/test/net_tests.cpp

src/test/util/setup_common.cpp

Do not pass CChainParams& to PeerManager::make
ClosedPublic
Actions

Revision Contents
Changeset List