Page MenuHomePhabricator
Differential D14659

[avalanche] Add a remote proof container to retain the proof set of our peers
ClosedPublic
Actions

Authored by Fabien on Oct 20 2023, 20:16.

Details

Reviewers
PiRK
bytesofman
Group Reviewers
Restricted Project
Commits
rABC0e0000749cf0: [avalanche] Add a remote proof container to retain the proof set of our peers
Summary

Currently unused outside of tests, this adds a new data structure to store the proofs from our peers. This links the proofid with the peer's node id and save the state (present or absent) as well as the last update time so we can process the data and determine if we're missing a proof or if a proof is getting dropped by the network.

Depends on D14658.

Test Plan
ninja check-avalanche-peermanager_tests

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 20 2023, 20:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 20 2023, 20:16
Fabien requested review of this revision.Oct 20 2023, 20:16
Fabien added a child revision: D14660: [avalanche] Clear the remote proofs upon node removal.Oct 20 2023, 20:21
Harbormaster completed remote builds in B25385: Diff 42720.Oct 20 2023, 20:37
PiRK accepted this revision.Oct 21 2023, 15:53
This revision is now accepted and ready to land.Oct 21 2023, 15:53
PiRK added inline comments.Oct 22 2023, 09:37
src/avalanche/peermanager.h
142 ↗(On Diff #42720)

It is not clear without reading a lot of code what present means. Locally present?

PiRK added inline comments.Oct 22 2023, 09:47
src/avalanche/peermanager.h
142 ↗(On Diff #42720)

I see that it is documented in the getremoteproofs RPC (D14662). Maybe that is enough.

bytesofman accepted this revision.Oct 23 2023, 18:34
Closed by commit rABC0e0000749cf0: [avalanche] Add a remote proof container to retain the proof set of our peers (authored by Fabien). · Explain WhyOct 25 2023, 10:16
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC0e0000749cf0: [avalanche] Add a remote proof container to retain the proof set of our peers.

Revision Contents
Changeset List

PathSize
src/
avalanche/
37 lines
13 lines
test/
57 lines

Diff 42773

View Options

src/avalanche/peermanager.h

Loading...
View Options

src/avalanche/peermanager.cpp

Loading...
View Options

src/avalanche/test/peermanager_tests.cpp

Loading...