Page MenuHomePhabricator
Differential D14661

[avalanche] Limit the remote proofs per peer
ClosedPublic
Actions

Authored by Fabien on Oct 20 2023, 20:22.

Details

Reviewers
PiRK
bytesofman
Group Reviewers
Restricted Project
Commits
rABC8065ce2ec6b1: [avalanche] Limit the remote proofs per peer
Summary

Ensure we don't store an unbound number of proofs from our peers, but allow for expansion as the network grows.

Depends on D14660.

Test Plan
ninja check-avalanche-peermanager_tests

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 20 2023, 20:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 20 2023, 20:22
Fabien requested review of this revision.Oct 20 2023, 20:22
Fabien mentioned this in D14662: [avalanche] Save the remote proofs from our avalanche outbound peers.Oct 20 2023, 20:27
Harbormaster completed remote builds in B25387: Diff 42722.Oct 20 2023, 20:44
PiRK requested changes to this revision.Oct 22 2023, 09:19
PiRK added a subscriber: PiRK.
PiRK added inline comments.
src/avalanche/peermanager.cpp
592–594 ↗(On Diff #42722)

The comment is wrong if our number of proofs decreases (only one proof is removed)

This revision now requires changes to proceed.Oct 22 2023, 09:19
Fabien updated this revision to Diff 42729.Oct 22 2023, 17:42

Handle peer list shrinkage

Harbormaster completed remote builds in B25394: Diff 42729.Oct 22 2023, 17:56
PiRK accepted this revision.Oct 22 2023, 18:12
This revision is now accepted and ready to land.Oct 22 2023, 18:12
bytesofman accepted this revision.Oct 23 2023, 18:12
Closed by commit rABC8065ce2ec6b1: [avalanche] Limit the remote proofs per peer (authored by Fabien). · Explain WhyOct 25 2023, 10:18
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC8065ce2ec6b1: [avalanche] Limit the remote proofs per peer.
Fabien mentioned this in rABCae165ac787d5: [avalanche] Save the remote proofs from our avalanche outbound peers.

Revision Contents
Changeset List

PathSize
src/
avalanche/
13 lines
15 lines
test/
79 lines

Diff 42775

View Options

src/avalanche/peermanager.h

Loading...
View Options

src/avalanche/peermanager.cpp

Loading...
View Options

src/avalanche/test/peermanager_tests.cpp

Loading...