Page MenuHomePhabricator
Differential D1476

Revert "Prepare a flag for charging for excessive utxo creation"
AbandonedPublic
Actions

Authored by Mengerian on Jun 4 2018, 23:37.

Details

Reviewers
jasonbcox
deadalnix
schancel
Group Reviewers
Restricted Project
Summary

This reverts commit ea91b58aac8be54912e0a2e251116336fd726d40.

This flag is no long necessary, as we have decided to use a different
method for weighting transation billing.

Test Plan
make check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
revert-D962
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2701
Build 3514: Bitcoin ABC Buildbot (legacy)
Build 3513: arc lint + arc unit

Event Timeline

schancel created this revision.Jun 4 2018, 23:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 4 2018, 23:37
schancel updated this revision to Diff 4059.Jun 4 2018, 23:38

Remove messed up merge

teamcity added a subscriber: teamcity.Jun 4 2018, 23:39

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 4 2018, 23:40

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B2698: Diff 4058!Jun 4 2018, 23:41
teamcity added a comment.Jun 4 2018, 23:41

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing failed.

teamcity added a comment.Jun 4 2018, 23:42

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2699: Diff 4059!Jun 4 2018, 23:42
schancel updated this revision to Diff 4062.Jun 5 2018, 00:16

What are my hands for?

teamcity added a comment.Jun 5 2018, 00:16

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

jasonbcox requested changes to this revision.Jun 5 2018, 00:33
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/config.h
67 ↗(On Diff #4062)

Looks like the merge borked here too, as this function definition shouldn't have moved.

This revision now requires changes to proceed.Jun 5 2018, 00:33
teamcity added a comment.Jun 5 2018, 00:47

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2700: Diff 4062.Jun 5 2018, 00:47
schancel added inline comments.Jun 5 2018, 03:51
src/config.h
67 ↗(On Diff #4062)

Weird. Thanks. I need a better way to visualize diffs before I put them up.

schancel updated this revision to Diff 4063.Jun 5 2018, 03:52

Unmove SetChainParams

teamcity added a comment.Jun 5 2018, 03:54

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B2701: Diff 4063.Jun 5 2018, 04:31
teamcity added a comment.Jun 5 2018, 04:31

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.Jun 6 2018, 22:14
jasonbcox accepted this revision.Jun 8 2018, 22:59
This revision is now accepted and ready to land.Jun 8 2018, 22:59
schancel planned changes to this revision.Nov 28 2018, 06:20
Mengerian commandeered this revision.Oct 13 2023, 14:38
Mengerian abandoned this revision.
Mengerian added a reviewer: schancel.

Revision Contents
Changeset List

PathSize
src/
11 lines
8 lines
17 lines
rpc/
8 lines
2 lines

Diff 4063

View Options

src/config.h

Loading...
View Options

src/config.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

src/validation.h

Loading...