This fixes a bug that breaks CashFusion when a round of fusion is starting.
Transaction.from_io now requires a list of TxInputs rather than a list of coin dictionnaries.
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABCe11af45c985a: [electrum] fix Transaction.from_io in fusion.util
python test_runner.py
search for usages of Transaction.from_io, confirm that inputs are all TxInput instances.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- fix_fusion_tx_from_io
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 25633 Build 50846: Build Diff electrum-tests Build 50845: arc lint + arc unit
Event Timeline
| electrum/electrumabc_plugins/fusion/tests/test_util.py | ||
|---|---|---|
| 38–42 | The components are raw protobuf data. | |
Comment Actions
Transaction.from_io now requires a list of TxInputs rather than a list of coin dictionnaries.
Is this the only remaining instance of the legacy form being used? Should update test plan to confirm this
Comment Actions
To the best of my knowledge, yes, but i also thought so the last time I fixed a similar issue. I plan to work on enabling the mypy linter, which should be able to detect such issues.