[chronik-client] Remove test dependency on reindexing node
ClosedPublic
Actions

Authored by bytesofman on Nov 16 2023, 13:55.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC84eb88e72f55: [chronik-client] Remove test dependency on reindexing node

Summary

chronik-client makes live API calls during unit tests. This should be changed, but requires new py scripts to mock actual chronik instances and server responses.

In the meantime, this is a quick patch to remove test dependency on non-abc infra.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Nov 16 2023, 13:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 16 2023, 13:55

remove unused var

Harbormaster completed remote builds in B25639: Diff 43119.Nov 16 2023, 13:58

Harbormaster completed remote builds in B25640: Diff 43120.

Fabien accepted this revision.Nov 16 2023, 14:05

This revision is now accepted and ready to land.Nov 16 2023, 14:05

Closed by commit rABC84eb88e72f55: [chronik-client] Remove test dependency on reindexing node (authored by bytesofman). · Explain WhyNov 16 2023, 14:06

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC84eb88e72f55: [chronik-client] Remove test dependency on reindexing node.

Revision Contents
Changeset List

Path

Size

modules/

chronik-client/

test/

test.ts

46 lines

Diff 43124

View Options

modules/chronik-client/test/test.ts

[chronik-client] Remove test dependency on reindexing nodeClosedPublicActions