Page MenuHomePhabricator

Process transactions in two loops in ConnectBlock instead of one.
ClosedPublic

Authored by deadalnix on Jun 6 2018, 23:46.

Details

Summary

This is a first step toward getting rid of transaction ordering.

Depends on D1479

Test Plan
make check
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
connectblockdualloop
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2711
Build 3534: Bitcoin ABC Buildbot (legacy)
Build 3533: arc lint + arc unit

Event Timeline

jasonbcox added inline comments.
src/validation.cpp
428

Should be a separate diff, but we can let it slide since this diff is small enough anyway.

2243

Is this safe to remove? Is i == 0 always the coinbase tx?

src/validation.cpp
428

Agreed on both counts.

2243

i = 0 is always the coinbase. This is a consensus rule.

This revision is now accepted and ready to land.Jun 7 2018, 22:55
This revision was automatically updated to reflect the committed changes.