As per title.
Depends on D1484
Details
Details
- Reviewers
Mengerian jasonbcox - Group Reviewers
Restricted Project - Commits
- rSTAGINGda5c0b3e10b3: Remove topological ordering constraint from block starting Nov, 15 2018
rABCda5c0b3e10b3: Remove topological ordering constraint from block starting Nov, 15 2018
Added an integration test checking for the proper activation of this feature.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| test/functional/abc-transaction-ordering.py | ||
|---|---|---|
| 12 ↗ | (On Diff #4082) | This comment is confusing. Seems like it should be changed to mention transaction ordering? |
| test/functional/abc-transaction-ordering.py | ||
|---|---|---|
| 50 ↗ | (On Diff #4100) | I see this used in a few tests, but don't see it used anywhere. What does it do? |
| 90 ↗ | (On Diff #4100) | engough -> enough |
| 227 ↗ | (On Diff #4100) | acivate -> activate |
| 240 ↗ | (On Diff #4100) | Actiavte -> Activate |
| 249 ↗ | (On Diff #4100) | Isn't block 4444 already out of order? 4444 doesn't look like it was made to be in-order, so I think this line is redundant. |
| test/functional/abc-transaction-ordering.py | ||
|---|---|---|
| 249 ↗ | (On Diff #4100) | We cleared this up offline. For posterity: the block number *is not* height. The height is the order they're generated. I think the numbers can be replaced with variable names instead, but I'll take care of that improvement later. |