[net processing] Move nPreferredDownload into PeerManagerImpl
ClosedPublic
Actions

Authored by PiRK on Nov 28 2023, 14:03.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC95fee839874a: [net processing] Move nPreferredDownload into PeerManagerImpl

Summary

Note that UpdatePreferredDownload was inlined in D14747 (this would be the next commit in this PR)

This is a partial backport of core#24543
https://github.com/bitcoin/bitcoin/pull/24543/commits/490c08f96a34ed436c3d2cf7b9a3ed72694b6147

Depends on D14862

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25754
Build 51088: Build Diff	lint-circular-dependencies · build-without-wallet · build-clang-tidy · build-diff · build-debug · build-clang
Build 51087: arc lint + arc unit

Event Timeline

PiRK created this revision.Nov 28 2023, 14:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 28 2023, 14:03

PiRK requested review of this revision.Nov 28 2023, 14:03

teamcity edited the summary of this revision. (Show Details)Nov 28 2023, 14:03

PiRK added a child revision: D14864: [net processing] Move block cache state into PeerManagerImpl.Nov 28 2023, 14:04

Harbormaster completed remote builds in B25754: Diff 43287.Nov 28 2023, 14:22

Fabien accepted this revision.Nov 29 2023, 10:15

This revision is now accepted and ready to land.Nov 29 2023, 10:15

Closed by commit rABC95fee839874a: [net processing] Move nPreferredDownload into PeerManagerImpl (authored by dergoegge <n.goeggi@gmail.com>, committed by PiRK). · Explain WhyNov 29 2023, 11:38

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC95fee839874a: [net processing] Move nPreferredDownload into PeerManagerImpl.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

10 lines

Diff 43287

View Options

[net processing] Move nPreferredDownload into PeerManagerImplClosedPublicActions