Page MenuHomePhabricator
Differential D14872

[test] Overhaul p2p_compactblocks.py
ClosedPublic
Actions

Authored by PiRK on Nov 29 2023, 08:12.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCb483581db7cd: [test] Overhaul p2p_compactblocks.py
Summary

backport of core#15660 and partial backport of core#20799
https://github.com/bitcoin/bitcoin/pull/20799/commits/cba909eaf938a775a9bd2dd994d06aba175e8713

Note that in our codebase test_node, ex_softfork_node and old_node are identical, as we use only version 1 compactblocks and NODE_NETWORK is the default services for TestP2PConn. As a result some tests were duplicated for no good reason. Removing this duplication divides the test time by 2.

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 29 2023, 08:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 29 2023, 08:12
PiRK requested review of this revision.Nov 29 2023, 08:12
teamcity edited the summary of this revision. (Show Details)Nov 29 2023, 08:12
PiRK updated this revision to Diff 43304.Nov 29 2023, 08:17

nits: make it clear that test_node and additional_test_node have no differences in services, remove a trailing comma

Harbormaster completed remote builds in B25766: Diff 43303.Nov 29 2023, 08:34
Harbormaster completed remote builds in B25767: Diff 43304.Nov 29 2023, 08:40
Fabien accepted this revision.Nov 29 2023, 10:20
Fabien added a subscriber: Fabien.

Nice !

This revision is now accepted and ready to land.Nov 29 2023, 10:20
PiRK added a child revision: D14874: [net processing] Remove fSupportsDesiredCmpctVersion and simplify sendcmpct processing.Nov 29 2023, 10:34
PiRK edited the summary of this revision. (Show Details)Nov 29 2023, 10:45
Closed by commit rABCb483581db7cd: [test] Overhaul p2p_compactblocks.py (authored by PiRK). · Explain WhyNov 29 2023, 16:22
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCb483581db7cd: [test] Overhaul p2p_compactblocks.py.
PiRK mentioned this in D15110: log improvements in p2p_compactblocks.Jan 8 2024, 15:40
PiRK mentioned this in D15112: remove unnecessary sync_blocks in p2p_compactblocks.Jan 9 2024, 09:01
PiRK mentioned this in rABC0a60df2de00c: remove unnecessary sync_blocks in p2p_compactblocks.Jan 9 2024, 13:21

Revision Contents
Changeset List

PathSize
test/
functional/
139 lines

Diff 43319

View Options

test/functional/p2p_compactblocks.py

Loading...