Page MenuHomePhabricator
Differential D15110

log improvements in p2p_compactblocks
ClosedPublic
Actions

Authored by PiRK on Jan 8 2024, 15:40.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC36642d9d2e60: log improvements in p2p_compactblocks
Summary

Removing the tabs was missed in D499
The "Running tests" log message is uneccessary. It was added by core because they had two sets of tests (pre-segwit and post-segwit)

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 8 2024, 15:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 8 2024, 15:40
PiRK requested review of this revision.Jan 8 2024, 15:40
Harbormaster completed remote builds in B26205: Diff 43975.Jan 8 2024, 15:56
bytesofman added a subscriber: bytesofman.Jan 8 2024, 19:03
bytesofman added inline comments.
test/functional/p2p_compactblocks.py
874 ↗(On Diff #43975)

removing this doesn't seem to be a log improvement?

878 ↗(On Diff #43975)

ditto & below

Fabien requested changes to this revision.Jan 8 2024, 19:41
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/p2p_compactblocks.py
874 ↗(On Diff #43975)

The log improvements could be split apart, they are unrelated

This revision now requires changes to proceed.Jan 8 2024, 19:41
PiRK updated this revision to Diff 43983.Jan 9 2024, 08:58
PiRK retitled this revision from remove unnecessary sync_blocks in p2p_compactblocks to log improvements in p2p_compactblocks.
PiRK edited the summary of this revision. (Show Details)

make this diff about logs only, split the other chages into a follow-up diff

PiRK added a child revision: D15112: remove unnecessary sync_blocks in p2p_compactblocks.Jan 9 2024, 09:01
PiRK edited the summary of this revision. (Show Details)Jan 9 2024, 09:01
Harbormaster completed remote builds in B26211: Diff 43983.Jan 9 2024, 09:15
Fabien accepted this revision.Jan 9 2024, 09:30
This revision is now accepted and ready to land.Jan 9 2024, 09:30
Closed by commit rABC36642d9d2e60: log improvements in p2p_compactblocks (authored by PiRK). · Explain WhyJan 9 2024, 13:21
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC36642d9d2e60: log improvements in p2p_compactblocks.

Revision Contents
Changeset List

PathSize
test/
functional/
26 lines

Diff 43985

View Options

test/functional/p2p_compactblocks.py

Loading...