[net processing] Remove fSupportsDesiredCmpctVersion and simplify sendcmpct processing
ClosedPublic
Actions

Authored by PiRK on Nov 29 2023, 10:34.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC54f5ea306d12: [net processing] Remove fSupportsDesiredCmpctVersion and simplify sendcmpct…

Summary

fSupportsDesiredCmpctVersion was never useful for Bitcoin ABC, as we support only a single version for compact blocks.

Backport the relevant part of core#20799 to make it go away and simplify the code.
https://github.com/bitcoin/bitcoin/pull/20799/commits/16730b64bb4a11995d792f626c8a63318e5eaeeb
https://github.com/bitcoin/bitcoin/pull/20799/commits/42882fc8fc2ef5c58eb963f7f1e852dd43de6c65
https://github.com/bitcoin/bitcoin/pull/20799/commits/25edb2b7bd4c41156fba09d0033a978e362435af
https://github.com/bitcoin/bitcoin/pull/20799/commits/a45d53cab556505048c387429fd07188e4c40c3d
https://github.com/bitcoin/bitcoin/pull/20799/commits/30c3a01874cf51d987a0ae2bb699bf50d82768ff
https://github.com/bitcoin/bitcoin/pull/20799/commits/d0e97741748aaaad2a89ca42e4898e7f01308b35

Depends on D14872

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 29 2023, 10:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 29 2023, 10:34

PiRK requested review of this revision.Nov 29 2023, 10:34

teamcity edited the summary of this revision. (Show Details)Nov 29 2023, 10:35

PiRK added a child revision: D14875: [net processing] Rename CNodeState compact block members.Nov 29 2023, 10:38

Harbormaster completed remote builds in B25769: Diff 43306.Nov 29 2023, 10:53

Fabien accepted this revision.Nov 29 2023, 12:08

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/net_processing.cpp
6977 ↗	(On Diff #43306)	Note for reviewers: that's the default for the other Make overload, so no change of behavior

This revision is now accepted and ready to land.Nov 29 2023, 12:08

rebase

Harbormaster completed remote builds in B25773: Diff 43317.Nov 29 2023, 16:32

Closed by commit rABC54f5ea306d12: [net processing] Remove fSupportsDesiredCmpctVersion and simplify sendcmpct… (authored by PiRK). · Explain WhyNov 29 2023, 17:07

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC54f5ea306d12: [net processing] Remove fSupportsDesiredCmpctVersion and simplify sendcmpct….

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

80 lines

Diff 43320

View Options

[net processing] Remove fSupportsDesiredCmpctVersion and simplify sendcmpct processingClosedPublicActions