Move peer state updates from headers message into separate function
ClosedPublic
Actions

Authored by PiRK on Dec 5 2023, 11:35.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC2d39859311e9: Move peer state updates from headers message into separate function

Summary

Review hint:
git show --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space

This is a partial backport of core#25454
https://github.com/bitcoin/bitcoin/pull/25454/commits/6d95cd3e7444ebaaabb64a76783ea3551530f1d7

Depends on D14909

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25827
Build 51234: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 51233: arc lint + arc unit

Event Timeline

PiRK created this revision.Dec 5 2023, 11:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 5 2023, 11:35

PiRK requested review of this revision.Dec 5 2023, 11:35

teamcity edited the summary of this revision. (Show Details)Dec 5 2023, 11:36

PiRK added a child revision: D14911: Cleanup received_new_header calculation to use WITH_LOCK.Dec 5 2023, 11:37

Harbormaster completed remote builds in B25827: Diff 43401.Dec 5 2023, 12:06

Fabien accepted this revision.Dec 5 2023, 16:49

This revision is now accepted and ready to land.Dec 5 2023, 16:49

Closed by commit rABC2d39859311e9: Move peer state updates from headers message into separate function (authored by Suhas Daftuar <sdaftuar@gmail.com>, committed by PiRK). · Explain WhyDec 5 2023, 18:25

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC2d39859311e9: Move peer state updates from headers message into separate function.

PiRK mentioned this in D15125: Add functions to construct locators without CChain.Jan 11 2024, 12:20

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

165 lines

Diff 43401

View Options

Move peer state updates from headers message into separate functionClosedPublicActions