Differential D15042
[Cashtab] Stop using port object to prevent port disconnect errors Authored by bytesofman on Dec 22 2023, 21:21.
Details
T3370 Looking into this more. Really we don't have any need to use the port object to maintain long lived connections. Cashtab extension requests are one-off msg passing. Chrome has method to support this, so use it instead. Note: The port passing is preserved for address sharing as, in testing, it was nontrivial to remove this extension-side. Also, have not seen the port disconnect error for the address passing feature, so lower priority to patch. npm run extension
Diff Detail
Event Timeline
Comment Actions Tested all ok in chrome however I feel like the usage of chrome APIs in this diff is the start of permanently locking the extension into the chrome ecosystem and any future plans to port this over to firefox, brave...etc will require significant refactor. Double checking here that this is the intention? On an unrelated note, wasn't there a recent diff that stopped creating new extension windows for each interaction with a button component? Not for solving in this diff but it's still occurring here.  Comment Actions
The use of extensionizer to run chrome APIs means we could (in theory) still extend to other browsers supported by extensionizer -- is the chrome param used directly anywhere? There would still be more work to do + testing to make sure everything works in another browser, but we aren't really adding more chrome APIs here, really we are getting rid of one. will check on the window killing situation. Comment Actions
What steps are you following to create this / what browser? Do you also see this in master or just this PR? I'm not able to repeat clicking on various CashtabBadge / GetAddress at components.cashtab.com Comment Actions ok that's fine, haven't seen a chrome param used elsewhere. We can deal with the window killing issue outside of this diff. | ||||||||||||||||||||||||||||||||