Page MenuHomePhabricator
Differential D1510

Added gitian signing keys and script to fetch them
ClosedPublic
Actions

Authored by jasonbcox on Jun 21 2018, 20:40.

Details

Reviewers
deadalnix
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING52b0de2d24a6: Added gitian signing keys and script to fetch them
rABC52b0de2d24a6: Added gitian signing keys and script to fetch them
Summary

WIP towards the signing infrastructure that we need. Completes T364.

Test Plan

run check-keys.sh

Diff Detail

Repository
rABC Bitcoin ABC
Branch
keys
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2792
Build 3694: Bitcoin ABC Buildbot (legacy)
Build 3693: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jun 21 2018, 20:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 21 2018, 20:40
teamcity added a subscriber: teamcity.Jun 21 2018, 20:42

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 21 2018, 21:18

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2758: Diff 4151.Jun 21 2018, 21:18
jasonbcox updated this revision to Diff 4192.Jul 3 2018, 14:58

Updated my fingerprint

teamcity added a comment.Jul 3 2018, 14:59

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 3 2018, 15:36

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2792: Diff 4192.Jul 3 2018, 15:36
schancel requested changes to this revision.Jul 5 2018, 14:55
schancel added inline comments.
contrib/gitian-signing/check-keys.sh
4

Have you tested this? I'm curious about the email in the keys file. How's that affect this command?

This revision now requires changes to proceed.Jul 5 2018, 14:55
jasonbcox requested review of this revision.Jul 5 2018, 17:42
jasonbcox marked an inline comment as done.
jasonbcox added inline comments.
contrib/gitian-signing/check-keys.sh
4

Yes, see the test plan. The emails do not affect the script because read fingerprint keyholder holds the fingerprint in fingerprint and the email in keyholder. Spaces are used as delimiters. See https://ss64.com/bash/read.html for more information.

schancel accepted this revision.Jul 6 2018, 16:52
schancel added inline comments.
contrib/gitian-signing/check-keys.sh
4

Oh, shoot I didn't notice the second parameter to read.

This revision is now accepted and ready to land.Jul 6 2018, 16:52
Closed by commit rABC52b0de2d24a6: Added gitian signing keys and script to fetch them (authored by jasonbcox). · Explain WhyJul 9 2018, 14:14
This revision was automatically updated to reflect the committed changes.
jasonbcox marked an inline comment as done.

Revision Contents
Changeset List

PathSize
contrib/
gitian-signing/
5 lines
3 lines
doc/
20 lines

Diff 4192

View Options

contrib/gitian-signing/check-keys.sh

Loading...
View Options

contrib/gitian-signing/keys.txt

Loading...
View Options

doc/gitian-signing.md

Loading...