Page MenuHomePhabricator

Added gitian signing keys and script to fetch them
ClosedPublic

Authored by jasonbcox on Jun 21 2018, 20:40.

Details

Summary

WIP towards the signing infrastructure that we need. Completes T364.

Test Plan

run check-keys.sh

Diff Detail

Repository
rABC Bitcoin ABC
Branch
keys
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2792
Build 3694: Bitcoin ABC Buildbot (legacy)
Build 3693: arc lint + arc unit

Event Timeline

schancel requested changes to this revision.Jul 5 2018, 14:55
schancel added inline comments.
contrib/gitian-signing/check-keys.sh
4

Have you tested this? I'm curious about the email in the keys file. How's that affect this command?

This revision now requires changes to proceed.Jul 5 2018, 14:55
jasonbcox marked an inline comment as done.
jasonbcox added inline comments.
contrib/gitian-signing/check-keys.sh
4

Yes, see the test plan. The emails do not affect the script because read fingerprint keyholder holds the fingerprint in fingerprint and the email in keyholder. Spaces are used as delimiters. See https://ss64.com/bash/read.html for more information.

schancel added inline comments.
contrib/gitian-signing/check-keys.sh
4

Oh, shoot I didn't notice the second parameter to read.

This revision is now accepted and ready to land.Jul 6 2018, 16:52
This revision was automatically updated to reflect the committed changes.
jasonbcox marked an inline comment as done.