Page MenuHomePhabricator

Fixed logging block diff times so that the order of blocks being received doesn't change what is logged
ClosedPublic

Authored by jasonbcox on Jun 22 2018, 00:12.

Details

Summary

Discovered this while debugging tests for D1442.

Test Plan

With D1442 applied:
build/test/functional/test_runner.py sendheaders-selfish-mining.py and
examine the logs at /tmp/bitcoin_test_runner_xxx/sendheaders-selfish-mining_xxx/node0/regtest/debug.log.

Note that the tmp files get cleaned up if the test passes, so make it fail
with assert() at the end of sendheaders-selfish-mining.py to see these logs.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
D1511-reduced
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2974
Build 4046: Bitcoin ABC Buildbot (legacy)
Build 4045: arc lint + arc unit

Event Timeline

Forgot to remove the assert() in the test

This revision is now accepted and ready to land.Jun 30 2018, 14:23

Feedback from D1515: moved one of the release notes to this diff.

Since the dependent diff is constantly slipping off my plate, I'm going to split this into two changes. Some of those changes belong in D1442 itself while the rest can be committed without a dependency.

Removed unnecessary variable that depends on D1442. Will add it back as part of D1442.

This revision is now accepted and ready to land.Jul 26 2018, 21:13
jasonbcox edited the test plan for this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.