Page MenuHomePhabricator
Differential D15174

[Cashtab] Add social links to Settings page
ClosedPublic
Actions

Authored by bytesofman on Jan 15 2024, 17:59.

Details

Reviewers
emack
Fabien
Group Reviewers
Restricted Project
Commits
rABC1b86841edee9: [Cashtab] Add social links to Settings page
Summary

T3404

Add Twitter and Facebook links to the bottom of the Settings Page

Test Plan

npm start, click hamburger menu, confirm icon looks ok, confirm link opens in a new tab

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cashtab-social
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26388
Build 52346: Build Diffcashtab-tests
Build 52345: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 15 2024, 17:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 15 2024, 17:59
bytesofman published this revision for review.Jan 15 2024, 18:01

image.png (456×488 px, 46 KB)

Harbormaster completed remote builds in B26371: Diff 44196.Jan 15 2024, 18:04
Fabien added a subscriber: Fabien.Jan 15 2024, 19:56

What is the point of a social media link in the wallet menu ?

bytesofman added a comment.Jan 16 2024, 00:09
In D15174#340765, @Fabien wrote:

What is the point of a social media link in the wallet menu ?

good point. for now it's mostly about getting the backlink.

bytesofman updated this revision to Diff 44215.Jan 16 2024, 00:10

Add to bottom of settings page and not the menu

bytesofman updated this revision to Diff 44216.Jan 16 2024, 00:12

remove unrelated line breaks

Harbormaster completed remote builds in B26388: Diff 44215.Jan 16 2024, 00:12
bytesofman updated this revision to Diff 44217.Jan 16 2024, 00:12

X instead of X.com

Harbormaster completed remote builds in B26389: Diff 44216.Jan 16 2024, 00:14
Harbormaster completed remote builds in B26390: Diff 44217.
emack requested changes to this revision.Jan 16 2024, 01:23
emack added a subscriber: emack.

The simple hyperlink text seems a bit out of place with the rest of the UI. I believe the web app convention is to hyperlink an image for social links.

e.g. https://about.twitter.com/en/who-we-are/brand-toolkit

image.png (160×1 px, 32 KB)

Perhaps get John to do one for X @cashtabwallet?

This revision now requires changes to proceed.Jan 16 2024, 01:23
bytesofman updated this revision to Diff 44246.Jan 16 2024, 15:43

better logos and styling + fb icon

Harbormaster completed remote builds in B26399: Diff 44246.Jan 16 2024, 15:46
bytesofman updated this revision to Diff 44249.Jan 16 2024, 16:59

better naming of styled components

Harbormaster completed remote builds in B26400: Diff 44249.Jan 16 2024, 17:02
Fabien added a comment.Jan 16 2024, 17:38

@bot preview-cashtab

teamcity awarded a token.Jan 16 2024, 17:38
teamcity added a comment.Jan 16 2024, 17:40

Build Bitcoin ABC Diffs / Diff Testing (preview-cashtab) passed.
Preview is available at http://51.68.37.192:41452 for the next 60 minutes.

Fabien added a comment.Jan 16 2024, 17:42

Sideshift is raising on exception in the preview:

Error: i.crypto.subtle is undefined
Fabien added a comment.Jan 16 2024, 17:43

The title and summary need an update

bytesofman added a comment.Jan 16 2024, 17:57
In D15174#341028, @Fabien wrote:

Sideshift is raising on exception in the preview:

Error: i.crypto.subtle is undefined

Cashtab previews won't work now that the headers require everything to be over https

bytesofman retitled this revision from [Cashtab] Add twitter social link to [Cashtab] Add social links to Settings page.Jan 16 2024, 17:57
bytesofman edited the summary of this revision. (Show Details)

image.png (795×518 px, 41 KB)

Fabien added a comment.Jan 16 2024, 19:16
In D15174#341035, @bytesofman wrote:
In D15174#341028, @Fabien wrote:

Sideshift is raising on exception in the preview:

Error: i.crypto.subtle is undefined

Cashtab previews won't work now that the headers require everything to be over https

OK, might be worth removing these headers for the preview then. Thanks for the screenshot

Fabien added a comment.Jan 16 2024, 19:16
In D15174#341036, @bytesofman wrote:

image.png (795×518 px, 41 KB)

LGTM

Fabien added a comment.Jan 16 2024, 19:17

Actually you could even remove the "Social" title, the icons are obvious enough imo

bytesofman updated this revision to Diff 44255.Jan 16 2024, 19:51

remove unnecessary title, "Cashtab Social"

bytesofman added a comment.Jan 16 2024, 19:51

image.png (579×498 px, 28 KB)

Harbormaster completed remote builds in B26404: Diff 44255.Jan 16 2024, 20:13
Fabien accepted this revision.Jan 16 2024, 20:40

Related: D15183

emack accepted this revision.Jan 16 2024, 22:25
This revision is now accepted and ready to land.Jan 16 2024, 22:25
Closed by commit rABC1b86841edee9: [Cashtab] Add social links to Settings page (authored by bytesofman). · Explain WhyJan 17 2024, 00:34
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC1b86841edee9: [Cashtab] Add social links to Settings page.

Revision Contents
Changeset List

PathSize
cashtab/
src/
components/
Common/
1 line
Configure/
11 lines

Diff 44215

View Options

cashtab/src/components/Common/CustomIcons.js

Loading...
View Options

cashtab/src/components/Configure/Configure.js

Loading...