Page MenuHomePhabricator

[Cashtab] Add social links to Settings page
ClosedPublic

Authored by bytesofman on Jan 15 2024, 17:59.

Details

Reviewers
emack
Fabien
Group Reviewers
Restricted Project
Commits
rABC1b86841edee9: [Cashtab] Add social links to Settings page
Summary

T3404

Add Twitter and Facebook links to the bottom of the Settings Page

Test Plan

npm start, click hamburger menu, confirm icon looks ok, confirm link opens in a new tab

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cashtab-social
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26400
Build 52370: Build Diffcashtab-tests
Build 52369: arc lint + arc unit

Event Timeline

What is the point of a social media link in the wallet menu ?

What is the point of a social media link in the wallet menu ?

good point. for now it's mostly about getting the backlink.

Add to bottom of settings page and not the menu

remove unrelated line breaks

emack requested changes to this revision.Jan 16 2024, 01:23
emack added a subscriber: emack.

The simple hyperlink text seems a bit out of place with the rest of the UI. I believe the web app convention is to hyperlink an image for social links.

e.g. https://about.twitter.com/en/who-we-are/brand-toolkit

image.png (160×1 px, 32 KB)

Perhaps get John to do one for X @cashtabwallet?

This revision now requires changes to proceed.Jan 16 2024, 01:23

better logos and styling + fb icon

better naming of styled components

Sideshift is raising on exception in the preview:

Error: i.crypto.subtle is undefined

The title and summary need an update

Sideshift is raising on exception in the preview:

Error: i.crypto.subtle is undefined

Cashtab previews won't work now that the headers require everything to be over https

bytesofman retitled this revision from [Cashtab] Add twitter social link to [Cashtab] Add social links to Settings page.Jan 16 2024, 17:57
bytesofman edited the summary of this revision. (Show Details)

image.png (795×518 px, 41 KB)

Sideshift is raising on exception in the preview:

Error: i.crypto.subtle is undefined

Cashtab previews won't work now that the headers require everything to be over https

OK, might be worth removing these headers for the preview then. Thanks for the screenshot

Actually you could even remove the "Social" title, the icons are obvious enough imo

remove unnecessary title, "Cashtab Social"

This revision is now accepted and ready to land.Jan 16 2024, 22:25