Page MenuHomePhabricator
Differential D15207

[Cashtab] Remove obsolete SendToken snapshot tests and replace with existing validation integration tests
ClosedPublic
Actions

Authored by bytesofman on Jan 19 2024, 06:25.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC834e341a078a: [Cashtab] Remove obsolete SendToken snapshot tests and replace with existing…
Summary

Depends on D15203

The new integration tests in SendTokenValidation.test.js are more comprehensive than the legacy snapshot test approach of SendToken.js.

SendTokenValidation.js is incomplete, but that is where all new integration tests for the SendToken component should go.

Delete the legacy snapshot test and rename SendTokenValidation.test.js to SendToken.test.js

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
update-home-tests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26480
Build 52530: Build Diffcashtab-tests
Build 52529: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 19 2024, 06:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 19 2024, 06:25
bytesofman published this revision for review.Jan 19 2024, 06:26
Harbormaster completed remote builds in B26480: Diff 44348.Jan 19 2024, 06:28
bytesofman added a child revision: D15208: [Cashtab] Improve CreateTokenForm component and add integration tests.Jan 19 2024, 06:58
bytesofman mentioned this in D15205: [Cashtab] Implement unified balance header.Jan 19 2024, 19:19
bytesofman updated this revision to Diff 44372.Jan 19 2024, 22:26

rebase

Harbormaster completed remote builds in B26498: Diff 44372.Jan 19 2024, 22:28
emack requested changes to this revision.Jan 20 2024, 10:37
emack added a subscriber: emack.

I'm getting a cherry picking error - can you try rebasing?

image.png (488×771 px, 68 KB)

This revision now requires changes to proceed.Jan 20 2024, 10:37
bytesofman updated this revision to Diff 44389.Jan 20 2024, 14:01

rebase

Harbormaster completed remote builds in B26511: Diff 44389.Jan 20 2024, 14:04
emack accepted this revision.Jan 20 2024, 22:18
This revision is now accepted and ready to land.Jan 20 2024, 22:18
Closed by commit rABC834e341a078a: [Cashtab] Remove obsolete SendToken snapshot tests and replace with existing… (authored by bytesofman). · Explain WhyJan 20 2024, 23:43
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC834e341a078a: [Cashtab] Remove obsolete SendToken snapshot tests and replace with existing….

Revision Contents
Changeset List

PathSize
cashtab/
src/
components/
Send/
__tests__/
436 lines
__snapshots__/

Diff 44348

View Options

cashtab/src/components/Send/__tests__/SendToken.test.js

Loading...
View Options

cashtab/src/components/Send/__tests__/SendTokenValidation.test.js

Loading...
View Options

cashtab/src/components/Send/__tests__/__snapshots__/SendToken.test.js.snap

Loading...