Page MenuHomePhabricator

[e.cash] Fix preview builds
ClosedPublic

Authored by bytesofman on Jan 24 2024, 18:51.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCefb8632a33ea: [e.cash] Fix preview builds
Summary

Disable https CSP header during e.cash preview builds

Test Plan

./contrib/teamcity/build-configurations.py preview-e.cash

note the url from the Preview is available at http://127.0.0.1:41868 for the next 60 minutes. output

curl -I http://127.0.0.1:41868 and no headers

Then, build a prod-like docker instance:

docker build -t ecash_local .
docker run -it --rm -p 3000:3000 ecash_local
curl -I http://localhost:3000

note the expected headers are there

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix-e.cash-previews
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26619
Build 52807: Build Diff
Build 52806: arc lint + arc unit

Event Timeline

get it to work with test plan

bytesofman added inline comments.
web/e.cash/next.preview.js
1 ↗(On Diff #44546)

this is 2023 bc all headers are generated by a linter in the repo.

fixed here: D15269

This revision is now accepted and ready to land.Jan 24 2024, 20:31
This revision was automatically updated to reflect the committed changes.