This diffs adds a radix tree to store the finalized transactions.
This is in a preliminary state for now and is only used for the
isfinaltransaction RPC, so it can be tested.
Details
Details
- Reviewers
PiRK - Group Reviewers
Restricted Project - Commits
- rABC999c85a5cf71: [avalanche] Build a radix tree of finalized txs
ninja all check-all
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- tx_radix_tree
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 26646 Build 52860: Build Diff lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang Build 52859: arc lint + arc unit
Event Timeline
Comment Actions
OK. The FIXME related to the never-ending polling for invalid txs is a bit worrying, but it is behind the off-by-default flag so it cannot cause damage in production.
Comment Actions
Not as worrying as I imagined, on second thought. A node with a sensible policy will not have to deal with many in-mempool txs becoming invalid, only double-spends will be affected until the node finally gets the corresponding finalized transaction and can stop processing the bad one.
| src/txmempool.cpp | ||
|---|---|---|
| 251 | maybe add a comment that this is a temporary behavior | |
| 251 | ignore incomplete comment, accidentaly submitted. | |
This comment was removed by Fabien.
Comment Actions
I am profoundly grateful and would like to express my sincere thanks for the priceless information you have given me. I am certain that your future pursuits will continue to impress and amaze me. driving directions