Page MenuHomePhabricator
Differential D15342

[chronik-client] Bump timeout for mocha tests
ClosedPublic
Actions

Authored by bytesofman on Jan 31 2024, 12:05.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf67d512e6898: [chronik-client] Bump timeout for mocha tests
Summary

Hitting the default 2s timeout about 30% of the time in these tests despite tests working as expected.

Bump timeout to 5s.

Test Plan

See D14915 instructions or wait for CI

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Jan 31 2024, 12:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 31 2024, 12:05
bytesofman published this revision for review.Jan 31 2024, 12:06
bytesofman mentioned this in D15278: [chronik-client] Support tx and block-txs endpoints in ChronikClientNode.
Harbormaster completed remote builds in B26793: Diff 44788.Jan 31 2024, 12:49
Fabien accepted this revision.Jan 31 2024, 13:12
Fabien added a subscriber: Fabien.
Fabien added inline comments.
modules/chronik-client/.mocharc.js
3 ↗(On Diff #44788)

Please bump even more, block generation for example can take time and we don't want flaky tests due to timeout. On the other hand it's fine to wait a few more seconds to make sure it's an actual failure.

This revision is now accepted and ready to land.Jan 31 2024, 13:12
Closed by commit rABCf67d512e6898: [chronik-client] Bump timeout for mocha tests (authored by bytesofman). · Explain WhyJan 31 2024, 18:17
This revision was automatically updated to reflect the committed changes.
bytesofman marked an inline comment as done.
bytesofman added a commit: rABCf67d512e6898: [chronik-client] Bump timeout for mocha tests.

Revision Contents
Changeset List

PathSize
modules/
chronik-client/
4 lines

Diff 44800

View Options

modules/chronik-client/.mocharc.js

Loading...