Add support for the chronik.tx(txid) and chronik.blockTxs(hashOrHeight, pageNumber, pageSize) endpoints in the in-node version of chronik-client
Convert value key from string to number. Convert timestamp and timeFirstSeen keys from string to number.
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABCb141caee22d5: [chronik-client] Support tx and block-txs endpoints in ChronikClientNode
teamcity CI tests in this diff, or see local testing approach from test plan at D14915
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
There are a very large number of changes, so older changes are hidden. Show Older Changes
Comment Actions
Failed tests logs:
====== /chronik-info: "before each" hook for "gives us the chronik info and throws expected error on bad server connection"./chronik-info "before each" hook for "gives us the chronik info and throws expected error on bad server connection" ======
Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/work/modules/chronik-client/test/integration/chronik_info.ts)
at listOnTimeout (node:internal/timers:559:17)
at processTimers (node:internal/timers:502:7)Each failure log is accessible here:
/chronik-info: "before each" hook for "gives us the chronik info and throws expected error on bad server connection"./chronik-info "before each" hook for "gives us the chronik info and throws expected error on bad server connection"
Comment Actions
Failed tests logs:
====== Gets available non-script endpoint info: "before each" hook for "New regtest chain".Gets available non-script endpoint info "before each" hook for "New regtest chain" ======
Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/work/modules/chronik-client/test/integration/non_script_endpoints.ts)
at listOnTimeout (node:internal/timers:559:17)
at processTimers (node:internal/timers:502:7)Each failure log is accessible here:
Gets available non-script endpoint info: "before each" hook for "New regtest chain".Gets available non-script endpoint info "before each" hook for "New regtest chain"
Comment Actions
This deserves to be a separate test and setup, I don't see the point of having it all in one as the steps are totally not correlated
| modules/chronik-client/src/ChronikClientNode.ts | ||
|---|---|---|
| 56 ↗ | (On Diff #44722) | Note: should be between 1 and 200, but certainly better to let the server handle the error here. Why not use a default value here ? Server default is 25. I don't understand why both args are not handled the same way, either both optional (the server will use defaults) or both with a sane default. |
| modules/chronik-client/test/integration/non_script_endpoints.ts | ||
| 11 ↗ | (On Diff #44722) | |
| modules/chronik-client/src/ChronikClientNode.ts | ||
|---|---|---|
| 56 ↗ | (On Diff #44722) | yeah it makes sense to have them both set to defaults if unspecified. |
Comment Actions
This deserves to be a separate test and setup, I don't see the point of having it all in one as the steps are totally not correlated
| modules/chronik-client/src/ChronikClientNode.ts | ||
|---|---|---|
| 266–269 ↗ | (On Diff #44744) | |
| test/functional/setup_scripts/chronik-client_blocktxs_and_tx.py | ||
|---|---|---|
| 42 ↗ | (On Diff #44749) | remove |
| 48 ↗ | (On Diff #44749) | The generate() method returns a list of the generated block hashes. Since you don't store the tip them you don't need to access the last array element |
| 51 ↗ | (On Diff #44749) | You can park the block as another step and check the txs are still available in the mempool |
| test/functional/setup_scripts/chronik-client_blocktxs_and_tx.py | ||
|---|---|---|
| 50 ↗ | (On Diff #44749) | yield False for the last step. This makes the setup to raise an error if this is unexpected and ensure both TS and python are in sync |
Comment Actions
Failed tests logs:
====== /chronik-info: "before each" hook for "gives us the chronik info and throws expected error on bad server connection"./chronik-info "before each" hook for "gives us the chronik info and throws expected error on bad server connection" ======
Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/work/modules/chronik-client/test/integration/chronik_info.ts)
at listOnTimeout (node:internal/timers:559:17)
at processTimers (node:internal/timers:502:7)Each failure log is accessible here:
/chronik-info: "before each" hook for "gives us the chronik info and throws expected error on bad server connection"./chronik-info "before each" hook for "gives us the chronik info and throws expected error on bad server connection"
Comment Actions
This timeout seems to occur when lint issues are present.
My workflow here is
arc diff
hit Y to the lint warnings
diff goes up, but lint warnings are in the diff
run arc lint locally, all good
push diff up again, lint warnings are gone, tests time out
not related to this diff specifically just an observation of a pattern from working on this one
Comment Actions
add park tests, clean up py script, improve querystring logic now that we have default params
Comment Actions
Failed tests logs:
====== /blockchain-info: "before each" hook for "gives us the blockchain info + throws expected error on bad connection"./blockchain-info "before each" hook for "gives us the blockchain info + throws expected error on bad connection" ======
Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/work/modules/chronik-client/test/integration/blockchain_info.ts)
at listOnTimeout (node:internal/timers:559:17)
at processTimers (node:internal/timers:502:7)Each failure log is accessible here:
/blockchain-info: "before each" hook for "gives us the blockchain info + throws expected error on bad connection"./blockchain-info "before each" hook for "gives us the blockchain info + throws expected error on bad connection"
| modules/chronik-client/src/ChronikClientNode.ts | ||
|---|---|---|
| 61 ↗ | (On Diff #44753) | This ternary makes no sense and is wrong. If the backend changes the default, say page size to 50, you'll get 50 tx if you ask 25. |
Comment Actions
Failed tests logs:
====== /block and /blocks: "before each" hook for "gives us the block and blocks after unparking the last block"./block and /blocks "before each" hook for "gives us the block and blocks after unparking the last block" ======
Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/work/modules/chronik-client/test/integration/block_and_blocks.ts)
at listOnTimeout (node:internal/timers:559:17)
at processTimers (node:internal/timers:502:7)Each failure log is accessible here:
/block and /blocks: "before each" hook for "gives us the block and blocks after unparking the last block"./block and /blocks "before each" hook for "gives us the block and blocks after unparking the last block"