And fix the errors.
We will add the .py extension in a follow-up commit so that these scripts remain linted.
The main entry point for the application will not get a .py extension, so add it to include in .arclint.
Depends on D15358
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABC9870622f1f01: [electrum] run flake8 on python scripts missing the .py extension
arc lint -- electrum/electrum-abc
Make sure ./electrum-abc still runs
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 26845 Build 53258: Build Diff electrum-tests Build 53257: arc lint + arc unit
Event Timeline
| electrum/scripts/get_merkle_root | ||
|---|---|---|
| 38–40 ↗ | (On Diff #44843) | E402 errors are "Module level import not at top of file". We ignore these errors because the sys.path.insert line must be before importing the related modules |
Comment Actions
don't add scripts/ to .arclint, we will simply rename those scripts with a .py extension
| electrum/electrum-abc | ||
|---|---|---|
| 56–57 | the entry point script had 2 unused imports? PROJECT_NAME AND _ ? | |
| electrum/scripts/get_merkle_root | ||
|---|---|---|
| 38 | For now it's not linter, you can avoid these changes and make them when adding the .py extension | |
| electrum/electrum-abc | ||
|---|---|---|
| 56–57 | That's correct. These must have become unused sometime since the monorepo migration, as this file was linted before. | |