Page MenuHomePhabricator
Differential D15429

[Cashtab] Helper method for initializing integration tests
ClosedPublic
Actions

Authored by bytesofman on Feb 12 2024, 20:53.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCd0fafffdf90d: [Cashtab] Helper method for initializing integration tests
Summary

Cashtab has added automated integration testing over the past few weeks. This implementation has involved some iterative discoveries and best practices.

Now that it is up and working, it's time to optimize and standardize the tests, so that it is easier to add new cases (and we do not end up accidentally testing different implementations of tests instead of test cases).

Add a helper function that initializes a mock-chronik-client instance with the data required to sync a cashtab wallet to the eCash chain.

Implement in AppIntegrations.test.js (for now, will be extended throughout the app in later diffs)

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Feb 12 2024, 20:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 12 2024, 20:53
Harbormaster completed remote builds in B27085: Diff 45166.Feb 12 2024, 20:57
teamcity added a comment.Feb 12 2024, 20:57
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Tail of the build log:

    > 15 |     }
         |      ^
      16 |
      17 |     async teardown() {
      18 |         await super.teardown();

      at new CustomEnvironment (config/jest/custom-environment.js:15:35)

FAIL src/components/Common/__tests__/QRCode.test.js
  ● Test suite failed to run

    ReferenceError: structuredClone is not defined

      13 |         this.global.Uint8Array = Uint8Array;
      14 |         this.global.ArrayBuffer = ArrayBuffer;
    > 15 |     }
         |      ^
      16 |
      17 |     async teardown() {
      18 |         await super.teardown();

      at new CustomEnvironment (config/jest/custom-environment.js:15:35)

FAIL src/components/Common/__tests__/ScanQRCode.test.js
  ● Test suite failed to run

    ReferenceError: structuredClone is not defined

      13 |         this.global.Uint8Array = Uint8Array;
      14 |         this.global.ArrayBuffer = ArrayBuffer;
    > 15 |     }
         |      ^
      16 |
      17 |     async teardown() {
      18 |         await super.teardown();

      at new CustomEnvironment (config/jest/custom-environment.js:15:35)

FAIL src/utils/__tests__/aliasUtils.test.js
  ● Test suite failed to run

    ReferenceError: structuredClone is not defined

      13 |         this.global.Uint8Array = Uint8Array;
      14 |         this.global.ArrayBuffer = ArrayBuffer;
    > 15 |     }
         |      ^
      16 |
      17 |     async teardown() {
      18 |         await super.teardown();

      at new CustomEnvironment (config/jest/custom-environment.js:15:35)


Test Suites: 30 failed, 30 total
Tests:       0 total
Snapshots:   0 total
Time:        5.419 s
Ran all test suites.
Build cashtab-tests failed with exit code 1
bytesofman updated this revision to Diff 45167.Feb 12 2024, 20:59

cleaning up comments

Harbormaster completed remote builds in B27086: Diff 45167.Feb 12 2024, 21:01
teamcity added a comment.Feb 12 2024, 21:01
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Tail of the build log:

    > 15 |     }
         |      ^
      16 |
      17 |     async teardown() {
      18 |         await super.teardown();

      at new CustomEnvironment (config/jest/custom-environment.js:15:35)

FAIL src/components/Etokens/__tests__/CreateTokenForm.test.js
  ● Test suite failed to run

    ReferenceError: structuredClone is not defined

      13 |         this.global.Uint8Array = Uint8Array;
      14 |         this.global.ArrayBuffer = ArrayBuffer;
    > 15 |     }
         |      ^
      16 |
      17 |     async teardown() {
      18 |         await super.teardown();

      at new CustomEnvironment (config/jest/custom-environment.js:15:35)

FAIL src/slpv1/__tests__/index.test.js
  ● Test suite failed to run

    ReferenceError: structuredClone is not defined

      13 |         this.global.Uint8Array = Uint8Array;
      14 |         this.global.ArrayBuffer = ArrayBuffer;
    > 15 |     }
         |      ^
      16 |
      17 |     async teardown() {
      18 |         await super.teardown();

      at new CustomEnvironment (config/jest/custom-environment.js:15:35)

FAIL src/components/Common/__tests__/ScanQRCode.test.js
  ● Test suite failed to run

    ReferenceError: structuredClone is not defined

      13 |         this.global.Uint8Array = Uint8Array;
      14 |         this.global.ArrayBuffer = ArrayBuffer;
    > 15 |     }
         |      ^
      16 |
      17 |     async teardown() {
      18 |         await super.teardown();

      at new CustomEnvironment (config/jest/custom-environment.js:15:35)


Test Suites: 30 failed, 30 total
Tests:       0 total
Snapshots:   0 total
Time:        5.516 s
Ran all test suites.
Build cashtab-tests failed with exit code 1
bytesofman added a child revision: D15431: [Cashtab] Create a standardized wrapper for test rendering.Feb 13 2024, 01:13
bytesofman updated this revision to Diff 45223.Feb 14 2024, 10:39

rebase and version bump

Harbormaster completed remote builds in B27126: Diff 45223.Feb 14 2024, 10:44
teamcity added a comment.Feb 14 2024, 10:44
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
bytesofman updated this revision to Diff 45236.Feb 14 2024, 14:23

rebase

Harbormaster completed remote builds in B27135: Diff 45236.Feb 14 2024, 15:01
bytesofman published this revision for review.Feb 14 2024, 17:17
bytesofman added inline comments.
cashtab/config/jest/custom-environment.js
8 ↗(On Diff #45166)

Started hitting this error when trying to test initializeCashtabStateForTests

https://github.com/jsdom/jsdom/issues/3363

So, update our custom test environment to handle this case. Change filename -- we were using a custom env before, but just to patch one other issue.

PiRK accepted this revision.Feb 15 2024, 13:16
This revision is now accepted and ready to land.Feb 15 2024, 13:16
Closed by commit rABCd0fafffdf90d: [Cashtab] Helper method for initializing integration tests (authored by bytesofman). · Explain WhyFeb 15 2024, 18:50
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCd0fafffdf90d: [Cashtab] Helper method for initializing integration tests.

Revision Contents
Changeset List

PathSize
cashtab/
config/
jest/
custom-environment.js
uint8array-environment.js
2 lines
2 lines
4 lines
2 lines
src/
components/
__tests__/
174 lines
fixtures/
__tests__/
154 lines
110 lines
12 lines

Diff 45274

View Options

cashtab/config/jest/custom-environment.js

Loading...
View Options

cashtab/config/jest/uint8array-environment.js

Loading...
View Options

cashtab/jest.config.js

Loading...
View Options

cashtab/package-lock.json

Loading...
View Options

cashtab/package.json

Loading...
View Options

cashtab/src/components/__tests__/AppIntegrations.test.js

Loading...
View Options

cashtab/src/components/fixtures/__tests__/index.test.js

Loading...
View Options

cashtab/src/components/fixtures/helpers.js

Loading...
View Options

cashtab/src/components/fixtures/mocks.js

Loading...
View Options

cashtab/src/components/fixtures/vectors.js

Loading...