Page MenuHomePhabricator

Added a block index tests for median time past
ClosedPublic

Authored by jasonbcox on Jul 11 2018, 23:22.

Details

Summary

Continues work on T355.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/test/blockindex_tests.cpp
135 ↗(On Diff #4279)

I wanted the init lists of these two lines to line up visually, but the linter won't let me. I can make the variable names match in length I guess? Any other ideas?

src/test/blockindex_tests.cpp
115 ↗(On Diff #4279)

It seems like you repeat the 12 information all over. A better alternative would be to define this as an std::array and use the size property.

135 ↗(On Diff #4279)

You could make an array of std::pair

Fixed according to feedback

deadalnix added inline comments.
src/test/blockindex_tests.cpp
114 ↗(On Diff #4298)

I get these are indices because there are several of them.

This revision is now accepted and ready to land.Jul 14 2018, 12:32
This revision was automatically updated to reflect the committed changes.