Page MenuHomePhabricator
Differential D1559

Added a block index tests for median time past
ClosedPublic
Actions

Authored by jasonbcox on Jul 11 2018, 23:22.

Details

Reviewers
deadalnix
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING338e6c825010: Added a block index tests for median time past
rABC338e6c825010: Added a block index tests for median time past
Summary

Continues work on T355.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D1559
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2866
Build 3836: Bitcoin ABC Buildbot (legacy)
Build 3835: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jul 11 2018, 23:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 11 2018, 23:22
teamcity added a subscriber: teamcity.Jul 11 2018, 23:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox added inline comments.Jul 11 2018, 23:24
src/test/blockindex_tests.cpp
135 ↗(On Diff #4279)

I wanted the init lists of these two lines to line up visually, but the linter won't let me. I can make the variable names match in length I guess? Any other ideas?

jasonbcox added a child revision: D1560: Added block index test for isValid.Jul 11 2018, 23:30
teamcity added a comment.Jul 11 2018, 23:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2852: Diff 4279.Jul 11 2018, 23:59
deadalnix added inline comments.Jul 12 2018, 11:45
src/test/blockindex_tests.cpp
115 ↗(On Diff #4279)

It seems like you repeat the 12 information all over. A better alternative would be to define this as an std::array and use the size property.

135 ↗(On Diff #4279)

You could make an array of std::pair

jasonbcox updated this revision to Diff 4298.Jul 13 2018, 18:37

Fixed according to feedback

jasonbcox marked 3 inline comments as done.Jul 13 2018, 18:37
teamcity added a comment.Jul 13 2018, 18:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 13 2018, 19:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2866: Diff 4298!Jul 13 2018, 19:18
deadalnix accepted this revision.Jul 14 2018, 12:32
deadalnix added inline comments.
src/test/blockindex_tests.cpp
114

I get these are indices because there are several of them.

This revision is now accepted and ready to land.Jul 14 2018, 12:32
jasonbcox updated this revision to Diff 4307.Jul 15 2018, 01:31

index -> indices

teamcity added a comment.Jul 15 2018, 01:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B2873: Diff 4307!Jul 15 2018, 02:12
teamcity added a comment.Jul 15 2018, 02:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

teamcity added a comment.Jul 15 2018, 02:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 15 2018, 02:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2873: Diff 4307.Jul 15 2018, 02:59
Closed by commit rABC338e6c825010: Added a block index tests for median time past (authored by jasonbcox). · Explain WhyJul 16 2018, 14:34
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
test/
51 lines

Diff 4298

View Options

src/test/blockindex_tests.cpp

Loading...