Page MenuHomePhabricator
Differential D1560

Added block index test for isValid
ClosedPublic
Actions

Authored by jasonbcox on Jul 11 2018, 23:30.

Details

Reviewers
deadalnix
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING20a4820c8f04: Added block index test for isValid
rABC20a4820c8f04: Added block index test for isValid
Summary

Continues work on T355.

Depends on D1559.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jul 11 2018, 23:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 11 2018, 23:30
teamcity added a subscriber: teamcity.Jul 11 2018, 23:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox updated this revision to Diff 4281.Jul 11 2018, 23:35

Switched to explicit list of BlockStatus instead of casting from ints due to feedback from a previous diff

teamcity added a comment.Jul 11 2018, 23:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 12 2018, 00:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2853: Diff 4280.Jul 12 2018, 00:13
teamcity added a comment.Jul 12 2018, 00:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2854: Diff 4281!Jul 12 2018, 00:17
deadalnix accepted this revision.Jul 12 2018, 11:55

Test failure looks unrelated to this diff.

This revision is now accepted and ready to land.Jul 12 2018, 11:55
deadalnix requested changes to this revision.Jul 12 2018, 11:57
deadalnix added inline comments.
src/test/blockindex_tests.cpp
164 ↗(On Diff #4281)

Wait, this isn't testing when the block is marked invalid, just the validity level.

This revision now requires changes to proceed.Jul 12 2018, 11:57
jasonbcox updated this revision to Diff 4299.Jul 13 2018, 19:16

Added missing invalid cases

teamcity added a comment.Jul 13 2018, 19:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox marked an inline comment as done.Jul 13 2018, 19:17
Harbormaster completed remote builds in B2867: Diff 4299.Jul 13 2018, 19:57
teamcity added a comment.Jul 13 2018, 19:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.Jul 14 2018, 12:30
This revision is now accepted and ready to land.Jul 14 2018, 12:30
Closed by commit rABC20a4820c8f04: Added block index test for isValid (authored by jasonbcox). · Explain WhyJul 16 2018, 14:38
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
test/
33 lines

Diff 4321

View Options

src/test/blockindex_tests.cpp

Loading...