[Chronik] Remove lifetime from `MemberSer` in `Group`
ClosedPublic
Actions

Authored by tobias_ruck on Mar 3 2024, 23:14.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCc79efae644a2: [Chronik] Remove lifetime from `MemberSer` in `Group`

Summary

Serializations use owned types like Bytes or [u8; 32] anyway, so it's currently unused, and removing the lifetime allows us to directly store serialized objects e.g. in a cache.

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tobias_ruck created this revision.Mar 3 2024, 23:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 3 2024, 23:14

tobias_ruck requested review of this revision.Mar 3 2024, 23:14

Harbormaster completed remote builds in B27619: Diff 45872.Mar 3 2024, 23:23

Build Bitcoin ABC Diffs / Diff Testing (chronik-client-integration-tests) failed.

Failed tests logs:

====== Get blocktxs, txs, and history for SLP NFT1 token txs: "before each" hook for "Gets an SLP NFT1 child genesis tx from the mempool".Get blocktxs, txs, and history for SLP NFT1 token txs "before each" hook for "Gets an SLP NFT1 child genesis tx from the mempool" ======
Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/work/modules/chronik-client/test/integration/token_slp_nft1.ts)
    at listOnTimeout (node:internal/timers:573:17)
    at processTimers (node:internal/timers:514:7)

Each failure log is accessible here:
Get blocktxs, txs, and history for SLP NFT1 token txs: "before each" hook for "Gets an SLP NFT1 child genesis tx from the mempool".Get blocktxs, txs, and history for SLP NFT1 token txs "before each" hook for "Gets an SLP NFT1 child genesis tx from the mempool"