test: add functional test for `-maxtipage` parameter
ClosedPublic
Actions

Authored by PiRK on Mar 12 2024, 17:09.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC23f60e0bd66b: test: add functional test for `-maxtipage` parameter

Summary

This PR adds a missing test for the -maxtipage parameter which controls what is the allowed maximum tip age for leaving IBD.

This is a backport of core#24154 and a partial backport of core#26477
https://github.com/bitcoin/bitcoin/pull/26477/commits/e4be0e9b0661a8af49c4e6d5472804913f04b8fc

The commit from core#26477 should allow catching of the introduced regression when backporting core#25704

Test Plan

cmake .. -GNinja
ninja check-functional

Check that the new test is detected by the test runner and completes successfully.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr25704

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 27834
Build 55222: Build Diff	build-clang-tidy · build-without-wallet · build-clang · build-diff · build-debug
Build 55221: arc lint + arc unit

Event Timeline

PiRK created this revision.Mar 12 2024, 17:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 12 2024, 17:09

PiRK requested review of this revision.Mar 12 2024, 17:09

teamcity edited the summary of this revision. (Show Details)Mar 12 2024, 17:09

can be reviewed by comparing with https://github.com/jamesob/bitcoin/blob/e4be0e9b0661a8af49c4e6d5472804913f04b8fc/test/functional/feature_maxtipage.py (file after the second commit, minus documentation nits from https://github.com/bitcoin/bitcoin/commit/faf44876db555f7488c8df96db9fa88b793f897c)

fix shebang and permissions, for consistency with all other tests.

Harbormaster completed remote builds in B27824: Diff 46137.Mar 12 2024, 17:28

Harbormaster completed remote builds in B27825: Diff 46138.Mar 12 2024, 17:45

bytesofman added a subscriber: bytesofman.Mar 12 2024, 23:23

bytesofman added inline comments.

test/functional/feature_maxtipage.py
1 ↗	(On Diff #46138)	would we change this to 2024?
4 ↗	(On Diff #46138)	is this difference in capitalization expected (vs the core PR, `nMaxTipAge` here and `-maxtipage` there it is not repeated below, though we do use `-maxtipage`

Fabien added a subscriber: Fabien.Mar 13 2024, 06:05

Fabien added inline comments.

test/functional/feature_maxtipage.py
1 ↗	(On Diff #46138)	This is backport from core, and core added this core in 2022 so the date is correct. This is their copyright
4 ↗	(On Diff #46138)	I don't like using the C++ var name in here either, could use -maxtipage instead
7 ↗	(On Diff #46138)	dito

nMaxTipAge -> -maxtipage

Partial backport of https://github.com/bitcoin/bitcoin/pull/25704/commits/faf44876db555f7488c8df96db9fa88b793f897c

Harbormaster completed remote builds in B27834: Diff 46147.Mar 13 2024, 08:04

In D15688#354247, @PiRK wrote:

nMaxTipAge -> -maxtipage

Partial backport of https://github.com/bitcoin/bitcoin/pull/25704/commits/faf44876db555f7488c8df96db9fa88b793f897c

Good catch

Fabien accepted this revision.Mar 13 2024, 08:34

This revision is now accepted and ready to land.Mar 13 2024, 08:34

Closed by commit rABC23f60e0bd66b: test: add functional test for `-maxtipage` parameter (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by PiRK). · Explain WhyMar 13 2024, 08:36

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC23f60e0bd66b: test: add functional test for `-maxtipage` parameter.