Page MenuHomePhabricator
Differential D15689

[Cashtab] Remove parenthesis around buttons
ClosedPublic
Actions

Authored by bytesofman on Mar 12 2024, 22:10.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCfb6e33b0b667: [Cashtab] Remove parenthesis around buttons
Summary

Parenthesis are visible around button components. This is a missed visual bug from simplifying button components.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
button-patch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27830
Build 55214: Build Diffcashtab-tests
Build 55213: arc lint + arc unit

Event Timeline

bytesofman created this revision.Mar 12 2024, 22:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 12 2024, 22:10
bytesofman published this revision for review.Mar 12 2024, 22:11

before this diff:

image.png (168×481 px, 15 KB)

after this diff:

image.png (168×481 px, 16 KB)

Harbormaster completed remote builds in B27830: Diff 46143.Mar 12 2024, 22:16
emack accepted this revision.Mar 13 2024, 08:30
This revision is now accepted and ready to land.Mar 13 2024, 08:30
Closed by commit rABCfb6e33b0b667: [Cashtab] Remove parenthesis around buttons (authored by bytesofman). · Explain WhyMar 13 2024, 11:24
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCfb6e33b0b667: [Cashtab] Remove parenthesis around buttons.

Revision Contents
Changeset List

PathSize
cashtab/
src/
components/
Send/
2 lines
2 lines

Diff 46143

View Options

cashtab/src/components/Send/SendToken.js

Loading...
View Options

cashtab/src/components/Send/SendXec.js

Loading...