[Cashtab] Improve and simplify fiat API
ClosedPublic
Actions

Authored by bytesofman on Mar 14 2024, 16:37.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC6a4ccfdd0098: [Cashtab] Improve and simplify fiat API

Summary

We should always throw an error if we do not get a good price. The "double" try...catch is not necessary.

Part of the codebase that has not been changed for years, implementing better practices. Also bumping the interval as 60s was resulting in rate limits.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

patch-forex

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 27872
Build 55296: Build Diff	cashtab-tests
Build 55295: arc lint + arc unit

Event Timeline

bytesofman created this revision.Mar 14 2024, 16:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 14 2024, 16:37

Harbormaster completed remote builds in B27872: Diff 46198.Mar 14 2024, 16:43

bytesofman published this revision for review.Mar 14 2024, 16:49

bytesofman added inline comments.

cashtab/src/hooks/useWallet.js
759	Before this diff, if a user had currency set to something other than usd, fiat interval would get usd -- then cashtabLoaded would complete -- then interval would clear and set to their selected currency. This double-ping also caused rate limit issues.

PiRK accepted this revision.Mar 14 2024, 17:19

PiRK added a subscriber: PiRK.

PiRK added inline comments.

cashtab/src/hooks/useWallet.js
674–697	style nit. I'm assuming that JS is like other languages in this regard, if we return in the `try` branch the rest of the code is unreachable. So if we reach the end we know that we didn't get a number in the API response or that we got an error.