Page MenuHomePhabricator

[qa] use calculate_fee for prioritise_transaction
ClosedPublic

Authored by schancel on Jul 23 2018, 16:36.

Details

Summary

As per title. Prepare this for fee calculation changes.

Test Plan
./test/functional/test_runner.py prioritise_transaction

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix-prioritise
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2952
Build 4004: Bitcoin ABC Buildbot (legacy)
Build 4003: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Jul 25 2018, 16:31
deadalnix added a subscriber: deadalnix.

This looks like a bag of unrelated changes, many of them in an unfinished state. I don't think this is what you intended to submit.

This revision now requires changes to proceed.Jul 25 2018, 16:31

Clean up unnecessary LogPrints

@deadalnix Yeah there was a bunch because I asked Jason to take a look at it. It's rebased now.

Address feedback from Jason about OP_PUSHDATA2

deadalnix requested changes to this revision.Jul 26 2018, 12:25
deadalnix added inline comments.
test/functional/prioritise_transaction.py
14 ↗(On Diff #4417)

Please avoid import star.

37 ↗(On Diff #4417)

There is a version of this in util.py , why is another one needed ?

106 ↗(On Diff #4417)

I don't understand what that means.

This revision now requires changes to proceed.Jul 26 2018, 12:25
test/functional/prioritise_transaction.py
37 ↗(On Diff #4417)

circular dependencies at the moment. I need to refactor some of the test suite.

Reword comment to be more intelligible.

This revision is now accepted and ready to land.Jul 26 2018, 20:30
This revision was automatically updated to reflect the committed changes.