Page MenuHomePhabricator
Differential D1587

[qa] use calculate_fee for prioritise_transaction
ClosedPublic
Actions

Authored by schancel on Jul 23 2018, 16:36.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING23e15185df78: [qa] use calculate_fee for prioritise_transaction
rABC23e15185df78: [qa] use calculate_fee for prioritise_transaction
Summary

As per title. Prepare this for fee calculation changes.

Test Plan
./test/functional/test_runner.py prioritise_transaction

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix-prioritise
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2952
Build 4004: Bitcoin ABC Buildbot (legacy)
Build 4003: arc lint + arc unit

Event Timeline

schancel created this revision.Jul 23 2018, 16:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 23 2018, 16:36
teamcity added a subscriber: teamcity.Jul 23 2018, 16:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel added a parent revision: D1581: Update CTxMemPoolEntry and BlockAssembler to billing cutoffs.Jul 23 2018, 16:42
teamcity added a comment.Jul 23 2018, 17:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2921: Diff 4374!Jul 23 2018, 17:17
schancel updated this revision to Diff 4385.Jul 24 2018, 22:42

Derp?

teamcity added a comment.Jul 24 2018, 22:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 24 2018, 23:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2926: Diff 4385!Jul 24 2018, 23:20
deadalnix requested changes to this revision.Jul 25 2018, 16:31
deadalnix added a subscriber: deadalnix.

This looks like a bag of unrelated changes, many of them in an unfinished state. I don't think this is what you intended to submit.

This revision now requires changes to proceed.Jul 25 2018, 16:31
schancel updated this revision to Diff 4409.Jul 25 2018, 17:57

Rebase on master

schancel updated this revision to Diff 4411.Jul 25 2018, 17:59

Clean up unnecessary LogPrints

teamcity added a comment.Jul 25 2018, 17:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel added a comment.Jul 25 2018, 18:00

@deadalnix Yeah there was a bunch because I asked Jason to take a look at it. It's rebased now.

teamcity added a comment.Jul 25 2018, 18:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel updated this revision to Diff 4412.Jul 25 2018, 18:03

Fix some feedback

teamcity added a comment.Jul 25 2018, 18:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel updated this revision to Diff 4414.Jul 25 2018, 18:10

Fix typo

schancel removed a parent revision: D1581: Update CTxMemPoolEntry and BlockAssembler to billing cutoffs.Jul 25 2018, 18:11
schancel added a child revision: D1581: Update CTxMemPoolEntry and BlockAssembler to billing cutoffs.
teamcity added a comment.Jul 25 2018, 18:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel updated this revision to Diff 4417.Jul 25 2018, 18:31

Address feedback from Jason about OP_PUSHDATA2

jasonbcox accepted this revision.Jul 25 2018, 18:33
Harbormaster completed remote builds in B2948: Diff 4409.Jul 25 2018, 18:36
teamcity added a comment.Jul 25 2018, 18:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

teamcity added a comment.Jul 25 2018, 18:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 25 2018, 18:42

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2950: Diff 4412!Jul 25 2018, 18:42
teamcity added a comment.Jul 25 2018, 18:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2949: Diff 4411!Jul 25 2018, 18:50
teamcity added a comment.Jul 25 2018, 18:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2952: Diff 4414!Jul 25 2018, 18:52
teamcity added a comment.Jul 25 2018, 19:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2954: Diff 4417.Jul 25 2018, 19:17
deadalnix requested changes to this revision.Jul 26 2018, 12:25
deadalnix added inline comments.
test/functional/prioritise_transaction.py
14 ↗(On Diff #4417)

Please avoid import star.

37 ↗(On Diff #4417)

There is a version of this in util.py , why is another one needed ?

106 ↗(On Diff #4417)

I don't understand what that means.

This revision now requires changes to proceed.Jul 26 2018, 12:25
schancel added inline comments.Jul 26 2018, 16:10
test/functional/prioritise_transaction.py
37 ↗(On Diff #4417)

circular dependencies at the moment. I need to refactor some of the test suite.

schancel updated this revision to Diff 4447.Jul 26 2018, 20:15

Update to depend on D1582

schancel added a parent revision: D1582: [qa] Use proper fee accounting in mempool_limit.Jul 26 2018, 20:15
teamcity added a comment.Jul 26 2018, 20:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel updated this revision to Diff 4448.Jul 26 2018, 20:29

Reword comment to be more intelligible.

teamcity added a comment.Jul 26 2018, 20:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix accepted this revision.Jul 26 2018, 20:30
This revision is now accepted and ready to land.Jul 26 2018, 20:30
teamcity added a comment.Jul 26 2018, 20:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2978: Diff 4447.Jul 26 2018, 20:59
teamcity added a comment.Jul 26 2018, 21:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2979: Diff 4448!Jul 26 2018, 21:08
Closed by commit rABC23e15185df78: [qa] use calculate_fee for prioritise_transaction (authored by schancel). · Explain WhyJul 26 2018, 21:23
This revision was automatically updated to reflect the committed changes.
Fabien mentioned this in D16443: test: use MiniWallet for mining_prioritisetransaction.py.Jul 11 2024, 14:28
Fabien mentioned this in rABC8a5202b62d2d: test: use MiniWallet for mining_prioritisetransaction.py.Jul 12 2024, 08:56

Revision Contents
Changeset List

PathSize
test/
functional/
54 lines

Diff 4414

View Options

test/functional/prioritise_transaction.py

Loading...