Page MenuHomePhabricator
Differential D1608

OP_2MUL & OP_2DIV implementation
AbandonedPublic
Actions

Authored by danconnolly on Jul 27 2018, 15:12.

Details

Reviewers
None
Summary

implements OP_2MUL & OP_2DIV
includes tests in opcode_tests.cpp and script_tests.json
tests include mul/div by zero, boundary conditions, negative zero

Test Plan

make check

Diff Detail

Branch
opcodes_2muldiv
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2991
Build 4077: arc lint + arc unit

Event Timeline

danconnolly created this revision.Jul 27 2018, 15:12
Harbormaster completed remote builds in B2991: Diff 4464.Jul 27 2018, 15:12
danconnolly added parent revisions: D1594: Rename monolith_opcodes.cpp to opcode_tests.cpp, D1593: Expand IsOpcodeDisabled() function to prepare for implementation of re-enabled opcodes in Magnetic update., D1592: Add SCRIPT_ENABLE_MAGNETIC_OPCODES flag to gate opcodes activation for the Magnetic upgrade..Jul 27 2018, 15:13
danconnolly added inline comments.
src/test/data/script_tests.json
1038

2MUL and 2DIV tests moved up here to with the "arithmetic operators" group of tests.

danconnolly planned changes to this revision.Jul 28 2018, 12:47

need to re-organize this, it has conflicting changes with some other of the diffs

danconnolly abandoned this revision.Aug 8 2018, 12:41

OP_2MUL & OP_2DIV removed from planned change.

Revision Contents
Changeset List

PathSize
src/
script/
13 lines
7 lines
test/
data/
41 lines
24 lines

Diff 4464

View Options

src/script/interpreter.cpp

Loading...
View Options

src/script/script.h

Loading...
View Options

src/test/data/script_tests.json

Loading...
View Options

src/test/opcode_tests.cpp

Loading...