Page MenuHomePhabricator

OP_INVERT implementation
AbandonedPublic

Authored by danconnolly on Jul 26 2018, 23:46.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

Implementation of the OP_INVERT opcode for the magnetic upgrade. The specification for this opcode is here.

Test Plan

make check

Diff Detail

Branch
opcodes_invert
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 3045
Build 4180: arc lint + arc unit

Event Timeline

danconnolly created this revision.Jul 26 2018, 23:46
danconnolly planned changes to this revision.Jul 28 2018, 12:44

the reorganiztion of script_tests.json shouldnt be in this diff

danconnolly updated this revision to Diff 4539.Aug 8 2018, 22:44
danconnolly edited the summary of this revision. (Show Details)

refactor the diffs to be more coherent and scope refined

schancel added a subscriber: schancel.Aug 9 2018, 01:10

There should be some additional testing in the magnetic anomaly activation test.

See here that there's already a test landed: https://reviews.bitcoinabc.org/rABC4714cd3622565b35d08fa71d932482ad760cc0ba

danconnolly edited the summary of this revision. (Show Details)Aug 9 2018, 07:59

There should be some additional testing in the magnetic anomaly activation test.

See here that there's already a test landed: https://reviews.bitcoinabc.org/rABC4714cd3622565b35d08fa71d932482ad760cc0ba

Yes, I see. Those tests didn't exist when we started this but I see they would be good to have. We would need to add tests for each opcode being implemented. The code of the tests doesn't seem very extendable, I think we'd need to refactor it.

Hmm, still thinking about how we can fit this in, time wise.

danconnolly abandoned this revision.Sep 4 2018, 09:28