Rename monolith_opcodes.cpp to opcode_tests.cpp
AbandonedPublic
Actions

Authored by jasonbcox on Jul 25 2018, 10:27.

Details

Reviewers

danconnolly
schancel

Group Reviewers

Restricted Project

Summary

The monolith_opcodes.cpp file contains tests for the opcodes that were re-enabled for the Monolith upgrade (May 2018).

In order to add tests to this file for future changes to opcodes, it should be renamed to be independent of the Monolith upgrade.

This change renames the file, and the test suite included in it, to opcode_tests.

Test Plan

To confirm that all tests still pass: make check
To confirm that the tests have been renamed and have not been lost: src/test/test_bitcoin --run_test=opcode_tests

Diff Detail

Branch

opcodes_3

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2936
Build 3974: arc lint + arc unit

Event Timeline

danconnolly created this revision.Jul 25 2018, 10:27

Harbormaster completed remote builds in B2936: Diff 4396.Jul 25 2018, 10:27

danconnolly added a child revision: D1598: OP_MUL implementation.Jul 25 2018, 22:15

danconnolly added a child revision: D1606: OP_INVERT implementation.Jul 26 2018, 23:48

danconnolly added a child revision: D1608: OP_2MUL & OP_2DIV implementation.Jul 27 2018, 15:13

danconnolly retitled this revision from rename monolith_opcodes tests to opcode_tests to Rename monolith_opcodes.cpp to opcode_tests.cpp.Jul 28 2018, 11:04

danconnolly edited the summary of this revision. (Show Details)

danconnolly edited the test plan for this revision. (Show Details)

danconnolly added a reviewer: Restricted Project.Jul 28 2018, 12:49

jasonbcox accepted this revision.Aug 6 2018, 15:50

This revision is now accepted and ready to land.Aug 6 2018, 15:50

danconnolly added a child revision: D1631: Enable the magnetic opcode changes in the opcode tests.Aug 8 2018, 22:35

danconnolly removed a child revision: D1606: OP_INVERT implementation.Aug 8 2018, 22:40

danconnolly removed a child revision: D1598: OP_MUL implementation.Aug 8 2018, 22:48

danconnolly added a child revision: D1638: OP_LSHIFT & OP_RSHIFT implementation.Aug 9 2018, 19:36

jasonbcox commandeered this revision.Sep 20 2018, 21:17

jasonbcox edited reviewers, added: danconnolly; removed: jasonbcox.

This revision now requires review to proceed.Sep 20 2018, 21:17