Differential D1606

OP_INVERT implementation
AbandonedPublic
Actions

Authored by danconnolly on Jul 26 2018, 23:46.

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

Implementation of the OP_INVERT opcode for the magnetic upgrade. The specification for this opcode is here.

Test Plan

make check

Diff Detail

Branch

opcodes_invert

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2987
Build 4070: arc lint + arc unit

Event Timeline

danconnolly created this revision.Jul 26 2018, 23:46

Harbormaster completed remote builds in B2987: Diff 4460.Jul 26 2018, 23:46

danconnolly added parent revisions: D1592: Add SCRIPT_ENABLE_MAGNETIC_OPCODES flag to gate opcodes activation for the Magnetic upgrade., D1593: Expand IsOpcodeDisabled() function to prepare for implementation of re-enabled opcodes in Magnetic update., D1594: Rename monolith_opcodes.cpp to opcode_tests.cpp.Jul 26 2018, 23:48

the reorganiztion of script_tests.json shouldnt be in this diff

danconnolly edited parent revisions, added: D1631: Enable the magnetic opcode changes in the opcode tests; removed: D1594: Rename monolith_opcodes.cpp to opcode_tests.cpp, D1592: Add SCRIPT_ENABLE_MAGNETIC_OPCODES flag to gate opcodes activation for the Magnetic upgrade..Aug 8 2018, 22:40

danconnolly edited the summary of this revision. (Show Details)

danconnolly added a reviewer: Restricted Project.

refactor the diffs to be more coherent and scope refined

Harbormaster completed remote builds in B3045: Diff 4539.Aug 8 2018, 22:44

There should be some additional testing in the magnetic anomaly activation test.

See here that there's already a test landed: https://reviews.bitcoinabc.org/rABC4714cd3622565b35d08fa71d932482ad760cc0ba

danconnolly edited the summary of this revision. (Show Details)Aug 9 2018, 07:59

In D1606#34272, @schancel wrote:

There should be some additional testing in the magnetic anomaly activation test.

See here that there's already a test landed: https://reviews.bitcoinabc.org/rABC4714cd3622565b35d08fa71d932482ad760cc0ba

Yes, I see. Those tests didn't exist when we started this but I see they would be good to have. We would need to add tests for each opcode being implemented. The code of the tests doesn't seem very extendable, I think we'd need to refactor it.

Hmm, still thinking about how we can fit this in, time wise.

danconnolly abandoned this revision.Sep 4 2018, 09:28