Page MenuHomePhabricator
Differential D1613

[cmake] Fix json test generation
ClosedPublic
Actions

Authored by weipin on Jul 30 2018, 13:55.

Details

Reviewers
schancel
deadalnix
Group Reviewers
Restricted Project
Restricted Owners Package(Owns No Changed Paths)
Commits
rSTAGING94637787aa85: [cmake] Fix json test generation
rABC94637787aa85: [cmake] Fix json test generation
Summary

Explicitly create dir "[build directory]/src/test/data".

Right now, make check will fail for "out-of-source build" -- OUTPUT not being able to create the *.json.h files. The error occurred on my env (a box running Mac OS X), also tested on a Ubuntu instance, same result. Creating the dir solves the problem.

Test Plan
mkdir build && cd build
cmake ..
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix-json-test-generation
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2996
Build 4086: Bitcoin ABC Buildbot (legacy)
Build 4085: arc lint + arc unit

Event Timeline

weipin created this revision.Jul 30 2018, 13:55
Owners added a reviewer: Restricted Owners Package.Jul 30 2018, 13:55
teamcity added a subscriber: teamcity.Jul 30 2018, 13:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 30 2018, 14:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2996: Diff 4471.Jul 30 2018, 14:38
jasonbcox requested changes to this revision.Aug 1 2018, 14:18
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/test/data/generate_header.py
21

This change doesn't seem related to the CMake change. Please split it out into its own diff.

This revision now requires changes to proceed.Aug 1 2018, 14:18
weipin updated this revision to Diff 4476.Aug 2 2018, 06:52

Remove unrelated changes and update summary

teamcity added a comment.Aug 2 2018, 06:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

weipin edited the summary of this revision. (Show Details)Aug 2 2018, 07:00
teamcity added a comment.Aug 2 2018, 07:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2999: Diff 4476.Aug 2 2018, 07:34
deadalnix accepted this revision.Aug 3 2018, 14:33
schancel accepted this revision.Aug 3 2018, 16:35
schancel removed a reviewer: jasonbcox.
This revision is now accepted and ready to land.Aug 3 2018, 16:35
Closed by commit rABC94637787aa85: [cmake] Fix json test generation (authored by weipin). · Explain WhyAug 4 2018, 00:22
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
test/
2 lines
data/
3 lines

Diff 4471

View Options

src/test/CMakeLists.txt

Loading...
View Options

src/test/data/generate_header.py

Loading...