Page MenuHomePhabricator

[cmake] Fix json test generation
ClosedPublic

Authored by weipin on Jul 30 2018, 13:55.

Details

Reviewers
schancel
deadalnix
Group Reviewers
Restricted Project
Restricted Owners Package(Owns No Changed Paths)
Commits
rSTAGING94637787aa85: [cmake] Fix json test generation
rABC94637787aa85: [cmake] Fix json test generation
Summary

Explicitly create dir "[build directory]/src/test/data".

Right now, make check will fail for "out-of-source build" -- OUTPUT not being able to create the *.json.h files. The error occurred on my env (a box running Mac OS X), also tested on a Ubuntu instance, same result. Creating the dir solves the problem.

Test Plan
mkdir build && cd build
cmake ..
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix-json-test-generation
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2999
Build 4092: Bitcoin ABC Buildbot (legacy)
Build 4091: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Jul 30 2018, 13:55
jasonbcox requested changes to this revision.Aug 1 2018, 14:18
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/test/data/generate_header.py
21 ↗(On Diff #4471)

This change doesn't seem related to the CMake change. Please split it out into its own diff.

This revision now requires changes to proceed.Aug 1 2018, 14:18

Remove unrelated changes and update summary

schancel removed a reviewer: jasonbcox.
This revision is now accepted and ready to land.Aug 3 2018, 16:35
This revision was automatically updated to reflect the committed changes.