Page MenuHomePhabricator
Differential D16218

[Cashtab] Update tx history to recognize paywall payments
ClosedPublic
Actions

Authored by emack on Fri, May 24, 04:39.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC9ae5f3a3ac7d: [Cashtab] Update tx history to recognize paywall payments
Summary

Updates the Tx component to recognize transactions using the new paywall lokad id and render accordingly in tx history.

image.png (168×575 px, 18 KB)

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emack created this revision.Fri, May 24, 04:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, May 24, 04:39
emack requested review of this revision.Fri, May 24, 04:39
emack edited the summary of this revision. (Show Details)Fri, May 24, 04:41
Harbormaster completed remote builds in B29121: Diff 47948.Fri, May 24, 04:43
bytesofman requested changes to this revision.Fri, May 24, 16:07

I don't think there's a reason to show the txid. Should be a link based on the txid.

If it's just a placeholder for now, a link to the block explorer for this txid is still more useful than a 64-character hex string.

This revision now requires changes to proceed.Fri, May 24, 16:07
emack updated this revision to Diff 47965.Sat, May 25, 12:45

Updated paywall description to render an explorer link to the paywalled article

Harbormaster completed remote builds in B29129: Diff 47965.Sat, May 25, 12:49
emack edited the summary of this revision. (Show Details)Sat, May 25, 13:17
bytesofman requested changes to this revision.Sat, May 25, 13:32
In D16218#367396, @emack wrote:

Updated paywall description to render an explorer link to the paywalled article

will this eventually be an ecashchat link?

cashtab/src/components/Home/Tx/index.js
426 ↗(On Diff #47965)

utf8 is the default

438 ↗(On Diff #47965)

add an integration test for this condition

This revision now requires changes to proceed.Sat, May 25, 13:32
emack updated this revision to Diff 47966.Sun, May 26, 13:32
emack marked 2 inline comments as done.

Removed redundant utf8 param and added integration test for invalid paywall transaction.

will this eventually be an ecashchat link?

yes, it will be a direct link to the paywalled article on ecashchat, which will be launched soon. The only way for users to see this is when the paywall feature is launched anyway.

Harbormaster completed remote builds in B29130: Diff 47966.Sun, May 26, 13:36
bytesofman accepted this revision.Sun, May 26, 21:07
This revision is now accepted and ready to land.Sun, May 26, 21:07
Closed by commit rABC9ae5f3a3ac7d: [Cashtab] Update tx history to recognize paywall payments (authored by emack). · Explain WhyMon, May 27, 00:16
This revision was automatically updated to reflect the committed changes.
emack added a commit: rABC9ae5f3a3ac7d: [Cashtab] Update tx history to recognize paywall payments.

Revision Contents
Changeset List

PathSize
cashtab/
8853 lines
src/
chronik/
fixtures/
68 lines
components/
Common/
13 lines
Home/
Tx/
__tests__/
86 lines
28 lines
config/
1 line

Diff 47968

View Options

cashtab/package-lock.json

Loading...
View Options

cashtab/src/chronik/fixtures/mocks.js

Loading...
View Options

cashtab/src/components/Common/CustomIcons.js

Loading...
View Options

cashtab/src/components/Home/Tx/__tests__/index.test.js

Loading...
View Options

cashtab/src/components/Home/Tx/index.js

Loading...
View Options

cashtab/src/config/opreturn.js

Loading...