[avalanche] don't use global g_avalanche in net_processing
ClosedPublic
Actions

Authored by PiRK on May 30 2024, 12:37.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCc8fabc010fdc: [avalanche] don't use global g_avalanche in net_processing

Summary

This diff is split out of D16224.

Pass the avalanche processor as a const pointer in the PeerManagerImpl constructor.
In most unit tests we currently pass it nullptr, except in processor_tests. This preserves the current behavior.

Depends on D16255

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29178
Build 57892: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 57891: arc lint + arc unit

Event Timeline

PiRK created this revision.May 30 2024, 12:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 30 2024, 12:37

PiRK requested review of this revision.May 30 2024, 12:37

remove the now redundant assertion

PiRK added a child revision: D16257: [avalanche] remove unnecessary nullptr checks for g_avalanche.May 30 2024, 13:08

Fabien requested changes to this revision.May 30 2024, 13:18

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/net_processing.cpp
8325 ↗	(On Diff #48045)	duplicated
8342 ↗	(On Diff #48045)	style nit: `[this, isStaker]`
src/net_processing.h
58 ↗	(On Diff #48045)	Can't be `const avalanche::Processor *const avalanche` ?